Merged
Conversation
Member
|
Thank you very much ! 👍 and nice catch |
Johann-S
approved these changes
Aug 31, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across jquery/jquery@0bf499c which links to mishoo/UglifyJS#2198. Apparently the default compression config of UglifyJS possibly produces code incompatible with IE10. I thought that this might possibly be relevant for this project here since IE10 is also supported (as discussed in #21416).
No idea whether this would really change anything in the output, maybe the constructs which would trigger this (something with
typeof) aren't even used but better safe than sorry. (Also, it might prevent problems in the future, especially if jQuery should get ditched).