Fix Example Carousel So It Works On Mobile#23470
Merged
XhmikosR merged 1 commit intotwbs:v4-devfrom Aug 15, 2017
Retroity:v4-dev
Merged
Fix Example Carousel So It Works On Mobile#23470XhmikosR merged 1 commit intotwbs:v4-devfrom Retroity:v4-dev
XhmikosR merged 1 commit intotwbs:v4-devfrom
Retroity:v4-dev
Conversation
The Example Carousel had an issue where the carousel text would not display on screens with less than 768px of width, meaning that the carousel text would not display on mobile. This fixes that issue.
XhmikosR
approved these changes
Aug 15, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Example Carousel available at https://getbootstrap.com/docs/4.0/examples/carousel/ had an issue where the carousel text would not display on screens with less than 768px of width, meaning that the carousel text would not display on mobile.
This fixes that by removing the d-none class from the Carousel items in the page.