Allow customization of colors, background and shadow for active, hover, focus#21670
Closed
pvdlg wants to merge 15 commits intotwbs:v4-devfrom
Closed
Allow customization of colors, background and shadow for active, hover, focus#21670pvdlg wants to merge 15 commits intotwbs:v4-devfrom
pvdlg wants to merge 15 commits intotwbs:v4-devfrom
Conversation
Contributor
|
Shouldn't the new color variables be set to a default value that's equal to what they were before this PR, to maximize compatibility? EDIT: Sorry, Github didn't show the diff of the _variables.scss file by default, I just skipped it. Read it now, it's exactly like I suggested. I like this, wonder why it hasn't gained any attention so far? |
Member
|
This ones mad out of date. Closing. Thanks though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21037, fixes #19353 and add similar type of variables for component that were missing some.
Basically all the colors properties that are derived from others (with
lightenanddarken) have now their own variable and are customizables.