Skip to content

added text-gray-dark class#19847

Merged
mdo merged 1 commit intotwbs:v4-devfrom
eddyerburgh:add-text-gray-utility
Sep 12, 2016
Merged

added text-gray-dark class#19847
mdo merged 1 commit intotwbs:v4-devfrom
eddyerburgh:add-text-gray-utility

Conversation

@eddyerburgh
Copy link
Contributor

Added a utility class .text-gray-dark. See #19842

@cvrebert
Copy link
Collaborator

cvrebert commented May 8, 2016

The premise for why this class would be useful seems reasonable enough.
But this should probably use $body-color instead and perhaps be named something like .text-color-default.
@mdo Thoughts?

@eddyerburgh
Copy link
Contributor Author

Ok, I'll update the request if @mdo agrees

@RyanZim
Copy link

RyanZim commented Aug 10, 2016

@mdo ping?

@mdo
Copy link
Member

mdo commented Sep 12, 2016

If the class is using the specific variable and value, it makes sense to not use the $body-bg. If the classes were .text-body, then maybe, but that's an unclear utility.

@mdo mdo added this to the v4.0.0-alpha.5 milestone Sep 12, 2016
@mdo mdo merged commit fe722c2 into twbs:v4-dev Sep 12, 2016
@mdo mdo mentioned this pull request Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants