Add variables for controlling button active/hover darken amount#19414
Add variables for controlling button active/hover darken amount#19414kevinkucharczyk wants to merge 1 commit intotwbs:v4-devfrom
Conversation
| background-color: darken($color, 17%); | ||
| border-color: darken($color, 25%); | ||
| background-color: darken($color, $btn-active-hover-bg-darken); | ||
| border-color: darken($color, $btn-active-hover-border-darken); |
There was a problem hiding this comment.
Line should be indented 6 spaces, but was indented 10 spaces
|
👍 or maybe just allow user to take full control of the bg color, border-color, and text color for hover state? and not just the amount of darken ? I personally always needed this kinda control of the buttons, like since BS 3. Anyway.. I hope this PR will land in alpha v3 :). |
|
I personally need buttons which are lightened on hover, not darkened. Why not to give full control of button hover, focus and active states through variables? Like |
|
Closing per @sqal's comment. This is the second or third PR I've seen deal with this. Opening a new issue to track and see what'd be more doable/helpful. Thanks though! |
fixes #19353