Fix bug multiple accordions collapse#18847
Conversation
There was a problem hiding this comment.
The collapse that you toggle needs to be within an accordion, so that it has a parent and thus triggers the code path that you've changed.
There was a problem hiding this comment.
Yes you're right thank you !
|
Any feedbacks @cvrebert ? |
|
+1 |
|
|
|
you're welcome @stafast 👍 |
|
Will this be merged soon? I would like to get this bug fix asap. Hopefully it will also fix my issue with nested collapse where clicking the child also closes the parent. |
|
I hope this PR will be merged soon, but no review since January... |
|
@Johann-S This is a bit out of date with the new card classes. Any chance you can update it? :D |
|
Sure I'll work on it :) |
js/tests/unit/collapse.js
Outdated
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
js/tests/unit/collapse.js
Outdated
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
js/tests/unit/collapse.js
Outdated
There was a problem hiding this comment.
Expected indentation of 6 space characters but found 8 indent
js/tests/unit/collapse.js
Outdated
There was a problem hiding this comment.
Expected indentation of 6 space characters but found 10 indent
js/tests/unit/collapse.js
Outdated
There was a problem hiding this comment.
Expected indentation of 6 space characters but found 8 indent
js/tests/unit/collapse.js
Outdated
There was a problem hiding this comment.
Expected indentation of 6 space characters but found 8 indent
js/tests/unit/collapse.js
Outdated
There was a problem hiding this comment.
Expected indentation of 6 space characters but found 10 indent
js/tests/unit/collapse.js
Outdated
There was a problem hiding this comment.
Expected indentation of 6 space characters but found 8 indent
js/tests/unit/collapse.js
Outdated
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
js/tests/unit/collapse.js
Outdated
There was a problem hiding this comment.
No magic number: 2 no-magic-numbers
js/tests/unit/collapse.js
Outdated
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
|
I think all it's done @mdo 💪 |
|
Thanks so much! I'll get this into the next alpha as soon as I can :). |
Fix #18824
I'll add a unit testCloses : #18824