Skip to content

Fix element precision bug in at media CSS elements widths #17388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
poulphunter wants to merge 1 commit into from
Closed

Fix element precision bug in at media CSS elements widths #17388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/layout/grid.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ See it in action in <a href="http://jsbin.com/ruxona/edit">this rendered example
@media (max-width: 32em) {
@include make-col-span(6);
}
@media (min-width: 32.1em) {
@media (min-width: 32.000001em) {
@include make-col-span(8);
}
}
Expand All @@ -221,7 +221,7 @@ See it in action in <a href="http://jsbin.com/ruxona/edit">this rendered example
@media (max-width: 32em) {
@include make-col-span(6);
}
@media (min-width: 32.1em) {
@media (min-width: 32.000001em) {
@include make-col-span(4);
}
}
Expand Down
8 changes: 4 additions & 4 deletions docs/layout/overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,16 +88,16 @@ We occasionally use media queries that go in the other direction (the given scre

{% highlight scss %}
// Extra small devices (portrait phones, less than 34em)
@media (max-width: 33.9em) { ... }
@media (max-width: 33.999999em) { ... }

// Small devices (landscape phones, less than 48em)
@media (max-width: 47.9em) { ... }
@media (max-width: 47.999999em) { ... }

// Medium devices (tablets, less than 62em)
@media (max-width: 61.9em) { ... }
@media (max-width: 61.9999999em) { ... }

// Large devices (desktops, less than 75em)
@media (max-width: 74.9em) { ... }
@media (max-width: 74.9999999em) { ... }

// Extra large devices (large desktops)
// No media query since the extra-large breakpoint has no upper bound on its width
Expand Down
4 changes: 2 additions & 2 deletions scss/mixins/_breakpoints.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@
}

// Maximum breakpoint width. Null for the largest (last) breakpoint.
// The maximum value is calculated as the minimum of the next one less 0.1.
// The maximum value is calculated as the minimum of the next one less 0.000001.
//
// >> breakpoint-max(sm, (xs: 0, sm: 34rem, md: 45rem))
// 44.9rem
@function breakpoint-max($name, $breakpoints: $grid-breakpoints) {
$next: breakpoint-next($name, $breakpoints);
@return if($next, breakpoint-min($next, $breakpoints) - 0.1, null);
@return if($next, breakpoint-min($next, $breakpoints) - 0.000001, null);
}

// Media of at least the minimum breakpoint width. No query for the smallest breakpoint.
Expand Down