Reducing redundancy in output of the semantic grid columns system#13426
Closed
dschenk wants to merge 2 commits intotwbs:masterfrom
Closed
Reducing redundancy in output of the semantic grid columns system#13426dschenk wants to merge 2 commits intotwbs:masterfrom
dschenk wants to merge 2 commits intotwbs:masterfrom
Conversation
…by introducing a generic make-column mixin
less/mixins/grid.less
Outdated
Collaborator
There was a problem hiding this comment.
So then there's no point in having the @gutter parameter.
Author
There was a problem hiding this comment.
True. Using the system in the following way
.module {
.make-xs-column(12, 10px);
.make-sm-column(6, 20px);
.make-md-column(3, 30px);
}
Did not make sense before the patch. It would just output and use the last given gutter (30px).
If somebody would want to use a custom gutter width she or he could do the following:
.module {
.make-column(30px)
.make-md-column(3);
}
We can remove the gutter params for the make-[bp]-column mixins then, right?
Author
|
@cvrebert What do you think? |
Collaborator
|
It's a good idea, but seems like it would break backwards compatibility for mixin-users. |
Member
|
Super into this though. I realized I screwed up the mixins far too late. Will slate for v4. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I often have the following use case when generating semantic columns:
Meaning I need a class that fills a variable amount of columns, depending on breakpoints.
Before this patch, the code above would generate the following CSS:
I propose to use the grid system in the following way to reduce this redundancy:
or:
This means using the make-column mixin whenever we want to define a semantic column class. In my opinion this disadvantage beats redundant output though.
Your thoughts?