.navbar-right outdent should apply to first child#12947
Closed
fleaflicker wants to merge 1 commit intotwbs:masterfrom
fleaflicker:patch-2
Closed
.navbar-right outdent should apply to first child#12947fleaflicker wants to merge 1 commit intotwbs:masterfrom fleaflicker:patch-2
fleaflicker wants to merge 1 commit intotwbs:masterfrom
fleaflicker:patch-2
Conversation
Right-floated elements appear in reverse order from their order in the markup. If you have more than one .navbar-right element, the "outdent" is applied to the wrong one.
Author
|
The fix proposed in this pull request is actually wrong too, the outdent needs to apply to the first |
Member
|
You'll need to include some extensive examples demonstrating any problem with navbar subcomponents. They're pretty on point right now overall as far as I know. Since you mention this fix is wrong, too, I'm going to close things out. Let's punt discussion to a new issue if you can put that together <3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right-floated elements appear in reverse order from their order in the markup.
If you have more than one
.navbar-rightelement, the "outdent" is applied to the wrong one.