Use of-type in Input Groups instead of child#12687
Closed
astratagem wants to merge 1 commit intotwbs:masterfrom
astratagem:st-of-type
Closed
Use of-type in Input Groups instead of child#12687astratagem wants to merge 1 commit intotwbs:masterfrom astratagem:st-of-type
of-type in Input Groups instead of child#12687astratagem wants to merge 1 commit intotwbs:masterfrom
astratagem:st-of-type
Conversation
Using the `:first-child` and `:last-child` pseudo-selectors in Input Groups assumes that there are no other elements before or after the element selected. That can be problematic when using something like `text-hide()` to use a form label prior to the addon.
Member
|
IE8 support, yo :). Can't do this until v4 when we drop IE8. |
Author
|
@mdo Aha, of course. |
Member
|
<3 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the
:first-childand:last-childpseudo-selectorsin Input Groups assumes that there are no other elements
before or after the element selected.
That can be problematic when using something like
text-hide()to use a form label prior to the addon.
This could apply in other parts of the codebase, but at the
moment I'm only concerned with Input Groups.