Skip to content

Fixes #10674: Form controls in disabled fieldset legend#11668

Closed
mdo wants to merge 3 commits intomasterfrom
form_controls_in_disabled_fieldset_legend
Closed

Fixes #10674: Form controls in disabled fieldset legend#11668
mdo wants to merge 3 commits intomasterfrom
form_controls_in_disabled_fieldset_legend

Conversation

@mdo
Copy link
Member

@mdo mdo commented Dec 2, 2013

This undoes the disabling of all form controls for those within the first legend in a disabled fieldset. It's a gnarly selector, and doesn't work for IE8, so I'll need to add a note to the docs, but it does the trick. See it in action: http://jsfiddle.net/tyVF4/3/.

/cc @darobin @cvrebert

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 2, 2013

This doesn't deal with buttons... Fixing them would probably require super-gnarly stuff; not fixing them would be an annoying inconsistency.

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 2, 2013

Also, are we sure that the relevant selector is first-of-type and not first-child? I admit the standardese isn't crystal clear on this.

@mdo
Copy link
Member Author

mdo commented Dec 5, 2013

I think it means first of type based on my reading of the spec. That said, we can noodle on this for v3.1, so not a rush right now. We can figure it out next week or so.

mdo added 2 commits December 14, 2013 14:52
Conflicts:
	dist/css/bootstrap.css
	dist/css/bootstrap.min.css
	docs-assets/js/raw-files.js
@mdo
Copy link
Member Author

mdo commented Dec 14, 2013

Just pushed a big update on this that should have all buttons in a disabled fieldset working fine, just like the inputs within that first fieldsets legend. See http://jsbin.com/usayeRU/3/.

This removes all the default disabled styles we applied to buttons—they're only there for IE8 and maybe IE9. That said, removing them made it super easy to re-enable the button. So, given it fubars IE to some degree, I don't think we can do this until v4 maybe.

Closing out with the full context until then.

@mdo mdo closed this Dec 14, 2013
@mdo mdo deleted the form_controls_in_disabled_fieldset_legend branch January 19, 2014 04:56
@mdo mdo mentioned this pull request Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants