Closed
Conversation
Member
|
is your whitespace off here? are you using tabs instead of spaces? |
Author
|
No, I'm using spaces instead of tabs. The whitespace changes (automatically done by the Save command in TextMate setup because of a whitespace bundle I have installed) are either a) removing trailing whitespace, or b) converting tabs to spaces. |
Member
|
Ah, interesting about the tabs/spaces. I'll run through our files once more and check for any spacing issues—we should be using soft-tabs with 2-spaces. Thinking about this now, we should add it to the docs for contributors. @peburrows, can you run the make to get the compiled CSS as part of this pull? |
Member
|
Actually, making this part of the next release. Got it accounted for in the 1.2-wip branch we have right now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure all the values required to setup the grid are dynamic and pulled from user-defined variables instead of being hard-coded.