Make better use of dropdown caret size variables#11142
Closed
santialbo wants to merge 1 commit intotwbs:masterfrom
santialbo:fix-carets
Closed
Make better use of dropdown caret size variables#11142santialbo wants to merge 1 commit intotwbs:masterfrom santialbo:fix-carets
santialbo wants to merge 1 commit intotwbs:masterfrom
santialbo:fix-carets
Conversation
Collaborator
|
Changing the meaning of an existing variable is backwards-incompatible, and we can't make those sorts of changes until v4. Introducing a new variable whose default value is based on the old variable would be fine though. |
Member
|
Closing out per @cvrebert's comment. I do hear you though—that could make sense come v4. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more a variable name concept fix rather than a bug fix.
@caret-width-largewas not being used for setting the height of the caret, now it is.@caret-width-base, I doubled the value and make the caret width to correspond with it.