Update alerts to hide the element instead of removing it - like modals#10752
Closed
navarr wants to merge 2 commits intotwbs:masterfrom
navarr:v4-change-alert-close-to-hide
Closed
Update alerts to hide the element instead of removing it - like modals#10752navarr wants to merge 2 commits intotwbs:masterfrom navarr:v4-change-alert-close-to-hide
navarr wants to merge 2 commits intotwbs:masterfrom
navarr:v4-change-alert-close-to-hide
Conversation
This allows alerts to be re-usable and unifies the the Bootstrap API to respond the same way - improving code usability and expectations. This is a breaking API change.
Collaborator
|
Due to backwards-compatibility constraints, we can't really do this until Bootstrap v4... |
Author
|
I'm aware of this. It's why v4 is in the branch name. |
Collaborator
|
v4 is so far off that it doesn't make sense to open a pull request for it at this point. |
Author
|
I consider that a terrible reason to essentially wipe what's a welcome and begged API change (for two years) off the roadmap. If that's the reason to ignore a change, then maybe SemVer is holding you back. |
Collaborator
|
|
Member
|
leaving these elements in the dom is not the right solution. |
Collaborator
|
@fat has deemed this WontFix/NotABug, even in Bootstrap v4, per #1845 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows alerts to be re-usable and unifies the the Bootstrap API to respond the same way - improving code usability and expectations. (Make the same functions do the same things? Why would we do that!)
This is a breaking API change.
This is a proper implementation of PR #1845, which has many +1's and has been ignored for about two years now.