Skip to content

Remove focus & hover states from bg-variant mixin #28444

@MartijnCuppens

Description

@MartijnCuppens

About this code:

a#{$parent},
button#{$parent} {
@include hover-focus {
background-color: darken($color, 10%) !important;
}
}

I think we should remove it. IMO focus and hover background states don't belong in these utilities and we are also not defining an active state here. We have the buttons with backgrounds, if this doesn't cover the needs I think the developer will need to write custom code, because it's quite specific.

I guess we can just remove the mixin, just use the background-color property in v5 and use the deprecate mixin to deprecate this in v4.

Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions