Fix incorrect nesting notations#20
Merged
scottdejonge merged 3 commits intoturretcss:masterfrom Apr 7, 2018
gian-reto:css-nesting
Merged
Fix incorrect nesting notations#20scottdejonge merged 3 commits intoturretcss:masterfrom gian-reto:css-nesting
scottdejonge merged 3 commits intoturretcss:masterfrom
gian-reto:css-nesting
Conversation
added 3 commits
April 6, 2018 21:45
W3C CSS Validator detects a Value Error: font Parse Error :~"0/0" a
This commit fixes 3 parse errors found by the W3C CSS Validator due to incorrect nesting. Per CSS Nesting spec, a nesting selector is mandatory.
Contributor
|
Wow! this is great. Good catch on the nested items! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried using turretcss with purifycss I stumbled upon 3 parsing errors due to "incorrect" nesting (based on this draft of the CSS Nesting spec).
While I was at it, I also fixed a value error which was already mentioned in the pull request #18 (I was worried it might cause additional issues with purifycss).
This is my first pull request in a long time, so I'd appreciate the feedback if I did something the wrong way 🎉!