Skip to content

Commit f6355dc

Browse files
authored
Remove NYTPhotoViewer from the app_with_spm_dependencies fixture (#6817)
1 parent 0241665 commit f6355dc

4 files changed

Lines changed: 14 additions & 20 deletions

File tree

fixtures/app_with_spm_dependencies/App/Project.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ let project = Project(
4141
.external(name: "AppCenterAnalytics"),
4242
.external(name: "AppCenterCrashes"),
4343
.external(name: "libzstd"),
44-
.external(name: "NYTPhotoViewer"),
4544
.external(name: "SVProgressHUD"),
4645
.external(name: "MarkdownUI"),
4746
.external(name: "GoogleMobileAds"),

fixtures/app_with_spm_dependencies/App/Sources/AppKit/AppKit.swift

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import GoogleMobileAds
88
import GoogleSignIn
99
import libzstd
1010
import MarkdownUI
11-
import NYTPhotoViewer
1211
import Sentry
1312
import SVProgressHUD
1413
import Yams
@@ -35,14 +34,13 @@ public enum AppKit {
3534
_ = DDOSLogger.sharedInstance
3635

3736
// Use AppCenter
38-
AppCenter.start(withAppSecret: "{Your App Secret}", services: [Analytics.self, Crashes.self])
37+
AppCenter.start(
38+
withAppSecret: "{Your App Secret}", services: [Analytics.self, Crashes.self]
39+
)
3940

4041
// Use libzstd
4142
_ = ZDICT_isError(0)
4243

43-
// Use NYTPhotoViewer
44-
_ = NYTPhotosOverlayView()
45-
4644
// Use SVProgressHUD
4745
SVProgressHUD.show()
4846

fixtures/app_with_spm_dependencies/Tuist/Package.resolved

Lines changed: 1 addition & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

fixtures/app_with_spm_dependencies/Tuist/Package.swift

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,25 @@ let package = Package(
2222
.package(url: "https://github.com/jpsim/Yams", .upToNextMajor(from: "5.0.6")),
2323
.package(url: "https://github.com/google/GoogleSignIn-iOS", .upToNextMajor(from: "7.0.0")),
2424
.package(url: "https://github.com/getsentry/sentry-cocoa", .upToNextMajor(from: "8.32.0")),
25-
.package(url: "https://github.com/CocoaLumberjack/CocoaLumberjack", .upToNextMajor(from: "3.8.4")),
25+
.package(
26+
url: "https://github.com/CocoaLumberjack/CocoaLumberjack", .upToNextMajor(from: "3.8.4")
27+
),
2628
.package(url: "https://github.com/facebook/zstd", exact: "1.5.5"),
27-
.package(url: "https://github.com/microsoft/appcenter-sdk-apple", .upToNextMajor(from: "5.0.4")),
29+
.package(
30+
url: "https://github.com/microsoft/appcenter-sdk-apple", .upToNextMajor(from: "5.0.4")
31+
),
2832
// Has SWIFTPM_MODULE_BUNDLE
29-
.package(url: "https://github.com/tuist/NYTPhotoViewer", branch: "develop"),
3033
.package(url: "https://github.com/Quick/Quick", exact: "7.4.0"),
3134
.package(url: "https://github.com/Quick/Nimble", exact: "13.2.0"),
3235
.package(url: "https://github.com/SVProgressHUD/SVProgressHUD", exact: "2.3.1"),
3336
// Has missing resources and its own resource bundle accessors
3437
.package(url: "https://github.com/braze-inc/braze-swift-sdk.git", exact: "8.4.0"),
3538
// Has an umbrella header where moduleName must be sanitized
3639
.package(url: "https://github.com/gonzalezreal/swift-markdown-ui", from: "2.4.0"),
37-
.package(url: "https://github.com/googleads/swift-package-manager-google-mobile-ads", from: "11.1.0"),
40+
.package(
41+
url: "https://github.com/googleads/swift-package-manager-google-mobile-ads",
42+
from: "11.1.0"
43+
),
3844
.package(url: "https://github.com/apple/swift-testing", .upToNextMajor(from: "0.6.0")),
3945
.package(path: "../LocalSwiftPackage"),
4046
.package(path: "../StringifyMacro"),

0 commit comments

Comments
 (0)