fix: do not throw error when resolving symlink of a plain directory#47
Merged
fix: do not throw error when resolving symlink of a plain directory#47
Conversation
80c1f07 to
b6d4869
Compare
b6d4869 to
4d1b42c
Compare
pepicrft
approved these changes
Oct 7, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of now,
resolveSymbolicLinkthrows an error if the passed path is not a symbolic link.For
tuist/tuistpurposes, we often don't know if a given path is or is not symbolic link since it depends on the user input or specificxcodebuildbehavior.I believe it's better to simply return the path without resolving if the file/directory is not a symlink instead of throwing.
Alternatively, we could add an
isSymbolicLinkmethod and let the consumers of the library ensureresolveSymbolicLinkis called only for actual symlinks. But intuist/tuist, we would have to do this dance almost everywhere we end up usingresolveSymbolicLink, which is why I'm leaning to the former.