Skip to content

Fix creating a temporary file#17

Merged
tsub merged 1 commit intotsub:masterfrom
ryosms:fix-creating-temporary-file
Jan 17, 2019
Merged

Fix creating a temporary file#17
tsub merged 1 commit intotsub:masterfrom
ryosms:fix-creating-temporary-file

Conversation

@ryosms
Copy link
Copy Markdown
Contributor

@ryosms ryosms commented Jan 10, 2019

This PR will be enable editing multi files with same name.

In the case below, first file was overwritten by another file.

  1. start editing my-file.txt in first console
    $ s3-edit edit s3://my-bucket/my-file.txt
  2. open another console and start editing my-file.txt on another bucket (or directory).
    $ s3-edit edit s3://other-bucket/my-file.txt
    if using vim, it displays attention here.
  3. end editing first console without saving.
    • if end editing with saving, it displays warning.
  4. s3://my-bucket/my-file.txt was overwritten by s3://other-bucket/my-file.txt

enable editing multi files with same name.
@tsub
Copy link
Copy Markdown
Owner

tsub commented Jan 17, 2019

I'm sorry, I had a cold and the review got late 🤧
I will review from now.

Copy link
Copy Markdown
Owner

@tsub tsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was worked.
@ryosms Thank you create PR.

@tsub tsub merged commit 5da8bf4 into tsub:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants