Skip to content

Also fix leaks from fixtures#205

Merged
andyleejordan merged 2 commits intomasterfrom
fix-fixture-leaks
Apr 15, 2015
Merged

Also fix leaks from fixtures#205
andyleejordan merged 2 commits intomasterfrom
fix-fixture-leaks

Conversation

@andyleejordan
Copy link
Copy Markdown
Collaborator

Same game as for bodies like in #203, just need to iterate over their list of fixtures.

As far as I can tell, we're not using joints, or we'd need to handle them too.

@BIOEvolveTD Try this on for size, it solves another significant portion of the memory leak.

Same game as for bodies, just need to iterate over their list of fixtures.
@BIOEvolveTD
Copy link
Copy Markdown
Collaborator

what branch is it?


From: Andrew Schwartzmeyer notifications@github.com
Sent: Tuesday, April 14, 2015 9:02 PM
To: tsoule88/evolvedTD
Cc: Robison, Barrie (brobison@uidaho.edu)
Subject: [evolvedTD] Also fix leaks from fixtures (#205)

Same game as for bodies like in #203#203, just need to iterate over their list of fixtures.

As far as I can tell, we're not using joints, or we'd need to handle them too.

@BIOEvolveTDhttps://github.com/BIOEvolveTD Try this on for size, it solves another significant portion of the memory leak.


You can view, comment on, or merge this pull request online at:

#205

Commit Summary

  • Also fix leaks from fixtures

File Changes

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com//pull/205.

@andyleejordan
Copy link
Copy Markdown
Collaborator Author

It is fix-fixture-leaks.

@BIOEvolveTD
Copy link
Copy Markdown
Collaborator

Generation 24, holding steady at 1.38 GB


From: Andrew Schwartzmeyer notifications@github.com
Sent: Tuesday, April 14, 2015 9:14:15 PM
To: tsoule88/evolvedTD
Cc: Robison, Barrie (brobison@uidaho.edu)
Subject: Re: [evolvedTD] Also fix leaks from fixtures (#205)

It is "fix-fixture-leaks."

Reply to this email directly or view it on GitHubhttps://github.com//pull/205#issuecomment-93182615.

@BIOEvolveTD
Copy link
Copy Markdown
Collaborator

Just cracked 50 generations for the first time.


From: Andrew Schwartzmeyer notifications@github.com
Sent: Tuesday, April 14, 2015 9:14 PM
To: tsoule88/evolvedTD
Cc: Robison, Barrie (brobison@uidaho.edu)
Subject: Re: [evolvedTD] Also fix leaks from fixtures (#205)

It is "fix-fixture-leaks."

Reply to this email directly or view it on GitHubhttps://github.com//pull/205#issuecomment-93182615.

@BIOEvolveTD
Copy link
Copy Markdown
Collaborator

Generation 70, holding at 1.53 Gb

We're through the looking glass here, people....


From: Robison, Barrie (brobison@uidaho.edu)
Sent: Tuesday, April 14, 2015 9:25 PM
To: tsoule88/evolvedTD; tsoule88/evolvedTD
Subject: Re: [evolvedTD] Also fix leaks from fixtures (#205)

Generation 24, holding steady at 1.38 GB


From: Andrew Schwartzmeyer notifications@github.com
Sent: Tuesday, April 14, 2015 9:14:15 PM
To: tsoule88/evolvedTD
Cc: Robison, Barrie (brobison@uidaho.edu)
Subject: Re: [evolvedTD] Also fix leaks from fixtures (#205)

It is "fix-fixture-leaks."

Reply to this email directly or view it on GitHubhttps://github.com//pull/205#issuecomment-93182615.

@andyleejordan
Copy link
Copy Markdown
Collaborator Author

Heck yes. I updated the Sway, I'm at 54 minutes, 90 generations, at less than 2 GB usage.

I'll go ahead and merge this, and think we can proceed from here confidently. Users should be able to perform any necessary inheritance tests without running into issues. (I mean, there are still leaks, but it's good enough now!)

andyleejordan added a commit that referenced this pull request Apr 15, 2015
@andyleejordan andyleejordan merged commit 9ce1320 into master Apr 15, 2015
@andyleejordan andyleejordan deleted the fix-fixture-leaks branch April 15, 2015 04:44
@andyleejordan andyleejordan mentioned this pull request Apr 15, 2015
@doug-graham
Copy link
Copy Markdown
Collaborator

I'll be using joints soon, once I solve the appendage triangular representation puzzle.

@BIOEvolveTD BIOEvolveTD restored the fix-fixture-leaks branch April 15, 2015 13:08
@andyleejordan andyleejordan deleted the fix-fixture-leaks branch April 17, 2015 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants