Better tag inheritance to match with latest scikit-learn versions#232
Better tag inheritance to match with latest scikit-learn versions#232
Conversation
rth
left a comment
There was a problem hiding this comment.
Overall looks good to me (but I don't know some other minor things would need fixing to make CI green).
|
OK, it seems that most tests pass. The only failing tests are for Python3.5 since I refactored the checks for them to match sklearn checks in v0.23 but for this Python version, there is no sklearn v0.23 package available. I will probably just patch the pipeline configuration to skip estimator checks for this case. |
|
Great!
Yeah, skipping them on Python 3.5 sounds good. |
|
Thanks a lot @rth ! Now I think we can use the estimator checks again :) |
The goal is to fix #231