Add poppygl-based STEP visual snapshots with PNG matcher#9
Merged
seveibar merged 3 commits intotscircuit:mainfrom Oct 7, 2025
Merged
Add poppygl-based STEP visual snapshots with PNG matcher#9seveibar merged 3 commits intotscircuit:mainfrom
seveibar merged 3 commits intotscircuit:mainfrom
Conversation
seveibar
reviewed
Oct 7, 2025
seveibar
approved these changes
Oct 7, 2025
Contributor
seveibar
left a comment
There was a problem hiding this comment.
Can you add visual snapshots for existing tests
seveibar
approved these changes
Oct 7, 2025
Contributor
seveibar
left a comment
There was a problem hiding this comment.
The angle on the box hole tests is non ideal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Introduces visual snapshot testing pipeline for STEP:
• expect(stepContent).toMatchStepSnapshot(import.meta.path, "name")
• New tests:
• visual-simple-box.test.ts (creates/validates snapshot)
• visual-simple-box-mismatch.test.ts (ensures diff artifact on change)
/claim #6
/closes #6