Prevent schematic traces from being drawn through net labels by 0hmX · Pull Request #60 · tscircuit/schematic-trace-solver

0hmX · 2025-09-12T07:04:00Z

introduce a new solver that will run at the end and adjust the labels

vercel · 2025-09-12T07:04:05Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
schematic-trace-solver	Ready	Preview	Comment	Sep 16, 2025 0:11am

imrishabh18 · 2025-09-12T08:53:12Z

tests/examples/__snapshots__/example16.snap.svg

Idk this seems a bit weird, both the traces are overlapping on the same trace to avoid the collision which is incorrect.

cc @seveibar

@imrishabh18 Please take a look at the new exmaple16.snap.svg file! I have added logic to handle the overlap! If its good, please mark this conversation as resolved!

Here is how it looks after the new update in logic

cc: @seveibar

This is still pretty messy, it's not helping that one of the traces is invalid (diagonal, not your fault but makes evaluating this annoying)

The thing about schematic lines is they're supposed to be readably separated, but the tight wrapping around the net labels makes it hard to read

I think this will work right!

lib/solvers/SchematicTraceLinesSolver/SchematicTraceSingleLineSolver2/pathOps.ts

seveibar · 2025-09-12T20:13:35Z

tests/examples/__snapshots__/example15.snap.svg

@@ -809,7 +809,7 @@ y-" data-x="-2.025" data-y="-2.7" cx="318.5204755614267" cy="526.0237780713342"
    <polyline data-points="-1.1099999999999999,2.600000000000002 -1.3099999999999998,2.600000000000002 -1.3099999999999998,2.8000000000000016 -1.1099999999999999,2.8000000000000016" data-type="line" data-label="" points="363.6459709379128,264.64112725671504 353.7824746807574,264.64112725671504 353.7824746807574,254.77763099955962 363.6459709379128,254.77763099955962" fill="none" stroke="purple" stroke-width="1" />


yea this isn't the right answer, it looks weird

@0hmX do you see the bug here?

The bug is because of the bun!

I added logs to every line! And for some reason, createElbow returns different amounts of segments! and some checks which get marked as false in browser (both chorm and firefox) is marked as true in bun!

it may be a floating point issue- you may be able to copy the input and reproduce in calculate-elbow https://github.com/tscircuit/calculate-elbow

I've never really seen a bun specific issue that didn't occur on the browser, maybe the example15 test input differs from the page input? I'm not sure, but I would try to get this reproduced in the browser as well-

have opened an issues for this tscircuit/calculate-elbow#15 for now! will keep working on this

seveibar

well, some of the examples look pretty good but others have major problems, we don't want to have any regressions, especially because other people won't be as good at debugging this code

one thing i would say, try to git checkout origin/main -- all the snap.svg files and regenerate so we're only seeing changed files

seveibar · 2025-09-12T20:15:47Z

@0hmX it's a very good attempt, the best so far, could probably be accepted if you find a way to improve the two examples we're commenting on here

/tip $50

algora-pbc · 2025-09-12T20:16:09Z

Please visit Algora to complete your tip via Stripe.

algora-pbc · 2025-09-12T20:16:19Z

🎉🎈 @0hmX has been awarded $50 by tscircuit! 🎈🎊

0hmX · 2025-09-15T15:53:36Z

Added new logic to make the turn smoother!
More padding so more clean

seveibar · 2025-09-15T21:40:51Z

tests/examples/__snapshots__/example26.snap.svg

@@ -0,0 +1,157 @@
+<svg width="640" height="640" viewBox="0 0 640 640" xmlns="http://www.w3.org/2000/svg">


the behavior of this snapshot is a regression i believe, calculate-elbow shouldn't generate a path like this

It is! I totally ignored it!

lib/solvers/TraceLabelOverlapAvoidanceSolver/rerouteCollidingTrace.ts

lib/solvers/TraceLabelOverlapAvoidanceSolver/TraceLabelOverlapAvoidanceSolver.ts

lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver.ts

lib/solvers/TraceLabelOverlapAvoidanceSolver/turnMinimization.ts

seveibar · 2025-09-15T23:03:26Z

lib/solvers/TraceLabelOverlapAvoidanceSolver/violation.ts

@@ -0,0 +1,25 @@
+import type { Point } from "@tscircuit/math-utils"
+
+export const findTraceViolationZone = (


rename file to match function name

lib/solvers/TraceLabelOverlapAvoidanceSolver/zShapeBalancing.ts

seveibar · 2025-09-15T23:04:17Z

tests/examples/__snapshots__/example16.snap.svg

@@ -66,10 +66,10 @@ x-" data-x="1.6" data-y="1.7049999999999998" cx="353.6" cy="230.12" r="3" fill="
    <polyline data-points="1.2000000000000002,0.30000000000000004 1.6,2.105" data-type="line" data-label="" points="308.80000000000007,387.47999999999996 353.6,185.32" fill="none" stroke="hsl(190, 100%, 50%, 0.8)" stroke-width="1" stroke-dasharray="4 2" />


new regression from last review, there is now no margin between the net label and the trace

This is not regression; the label is making a 90-degree turn! Look at the original image; it was having a diagonal, due to my cleanup logic to have a minimal number of segments; it removes the point that was making the diagonal (not a special logic to remove diagonal, but luck), which caused it to look like that! the labels padding logic is skiped for the labels that are attached to the current line! Or else we could have cases where the labels block the exit path and such!

ok we can go with it, but what i'm saying is that in one of my reviews the behavior was better, it's an improvement from the main branch however

lib/solvers/TraceLabelOverlapAvoidanceSolver/pathUtils.ts

seveibar

there's one regression and some minor code quality stuff, we're very close

seveibar · 2025-09-16T00:39:31Z

lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver.ts

+            instance.netLabelPlacementSolver
+          ) {
+            const { netLabelPlacements } =
+              instance.traceLabelOverlapAvoidanceSolver.getOutput()


getOutput is supposed to be on the SchematicTracePipelineSolver, although you can keep the function on the traceLabelOverlapAvoidanceSolver solver. But it's VERY IMPORTANT that users just do solver.solve() and solver.getOutput() where the solver is the SchematicTracePipelineSolver

lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver.ts

seveibar

you can do the getOutput() for SchematicTraceSolver in the next PR, this is good enough to merge

seveibar · 2025-09-16T00:42:35Z

/tip $25 don't forget to update to add getOutput() to the main pipeline solver as per my comment

algora-pbc · 2025-09-16T00:42:54Z

🎉🎈 @0hmX has been awarded $25 by tscircuit! 🎈🎊

algora-pbc · 2025-09-16T00:42:55Z

Please visit Algora to complete your tip via Stripe.

vercel bot deployed to Preview September 12, 2025 07:04 View deployment

vercel bot deployed to Preview September 12, 2025 07:07 View deployment

vercel bot deployed to Preview September 12, 2025 07:12 View deployment

imrishabh18 requested changes Sep 12, 2025

View reviewed changes

vercel bot deployed to Preview September 12, 2025 18:28 View deployment

seveibar reviewed Sep 12, 2025

View reviewed changes

lib/solvers/SchematicTraceLinesSolver/SchematicTraceSingleLineSolver2/pathOps.ts Outdated Show resolved Hide resolved

seveibar reviewed Sep 12, 2025

View reviewed changes

seveibar requested changes Sep 12, 2025

View reviewed changes

algora-pbc bot added the 💰 Rewarded label Sep 12, 2025

0hmX force-pushed the net-labels branch from 78621a5 to 9bb05dc Compare September 15, 2025 07:08

vercel bot deployed to Preview September 15, 2025 07:08 View deployment

vercel bot deployed to Preview September 15, 2025 15:51 View deployment

0hmX added 2 commits September 16, 2025 03:00

Prevent schematic traces from being drawn through net labels

17c6e3e

WIP

f15d47a

0hmX force-pushed the net-labels branch from c3d7ca1 to f15d47a Compare September 15, 2025 21:31

vercel bot deployed to Preview September 15, 2025 21:32 View deployment

format

dbdafcc

vercel bot deployed to Preview September 15, 2025 21:33 View deployment

remove log

5815d09

vercel bot deployed to Preview September 15, 2025 21:35 View deployment

seveibar reviewed Sep 15, 2025

View reviewed changes

lib/solvers/TraceLabelOverlapAvoidanceSolver/rerouteCollidingTrace.ts Outdated Show resolved Hide resolved

seveibar reviewed Sep 15, 2025

View reviewed changes

lib/solvers/TraceLabelOverlapAvoidanceSolver/TraceLabelOverlapAvoidanceSolver.ts Show resolved Hide resolved

seveibar reviewed Sep 15, 2025

View reviewed changes

lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver.ts Show resolved Hide resolved

seveibar reviewed Sep 15, 2025

View reviewed changes

lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver.ts Show resolved Hide resolved

0hmX added 2 commits September 16, 2025 03:34

WIP

fd2c9a1

WIP

fbb3c8f

vercel bot deployed to Preview September 15, 2025 22:16 View deployment

WIP

f190bcd

vercel bot deployed to Preview September 15, 2025 22:59 View deployment

WIP

12f86f3

vercel bot deployed to Preview September 15, 2025 23:02 View deployment

seveibar reviewed Sep 15, 2025

View reviewed changes

lib/solvers/TraceLabelOverlapAvoidanceSolver/turnMinimization.ts Show resolved Hide resolved

seveibar reviewed Sep 15, 2025

View reviewed changes

lib/solvers/TraceLabelOverlapAvoidanceSolver/zShapeBalancing.ts Show resolved Hide resolved

seveibar reviewed Sep 15, 2025

View reviewed changes

lib/solvers/TraceLabelOverlapAvoidanceSolver/pathUtils.ts Outdated Show resolved Hide resolved

seveibar reviewed Sep 15, 2025

View reviewed changes

WIP

df88d7f

vercel bot deployed to Preview September 15, 2025 23:21 View deployment

WIP

91798f8

vercel bot deployed to Preview September 15, 2025 23:55 View deployment

WIP

ee551e0

vercel bot deployed to Preview September 15, 2025 23:56 View deployment

WIP

63b6414

vercel bot deployed to Preview September 16, 2025 00:11 View deployment

seveibar reviewed Sep 16, 2025

View reviewed changes

lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver.ts Show resolved Hide resolved

seveibar approved these changes Sep 16, 2025

View reviewed changes

seveibar merged commit 6cbd97a into tscircuit:main Sep 16, 2025
5 checks passed

0hmX mentioned this pull request Sep 22, 2025

add getOutput #64

Closed

		@@ -809,7 +809,7 @@ y-" data-x="-2.025" data-y="-2.7" cx="318.5204755614267" cy="526.0237780713342"
		<polyline data-points="-1.1099999999999999,2.600000000000002 -1.3099999999999998,2.600000000000002 -1.3099999999999998,2.8000000000000016 -1.1099999999999999,2.8000000000000016" data-type="line" data-label="" points="363.6459709379128,264.64112725671504 353.7824746807574,264.64112725671504 353.7824746807574,254.77763099955962 363.6459709379128,254.77763099955962" fill="none" stroke="purple" stroke-width="1" />

		@@ -0,0 +1,157 @@
		<svg width="640" height="640" viewBox="0 0 640 640" xmlns="http://www.w3.org/2000/svg">

		@@ -0,0 +1,25 @@
		import type { Point } from "@tscircuit/math-utils"

		export const findTraceViolationZone = (

		@@ -66,10 +66,10 @@ x-" data-x="1.6" data-y="1.7049999999999998" cx="353.6" cy="230.12" r="3" fill="
		<polyline data-points="1.2000000000000002,0.30000000000000004 1.6,2.105" data-type="line" data-label="" points="308.80000000000007,387.47999999999996 353.6,185.32" fill="none" stroke="hsl(190, 100%, 50%, 0.8)" stroke-width="1" stroke-dasharray="4 2" />

Conversation

0hmX commented Sep 12, 2025

Uh oh!

vercel bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seveibar Sep 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seveibar left a comment

Choose a reason for hiding this comment

Uh oh!

seveibar commented Sep 12, 2025

Uh oh!

algora-pbc bot commented Sep 12, 2025

Uh oh!

algora-pbc bot commented Sep 12, 2025

Uh oh!

0hmX commented Sep 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

seveibar left a comment

Choose a reason for hiding this comment

Uh oh!

seveibar Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

seveibar left a comment

Choose a reason for hiding this comment

Uh oh!

seveibar commented Sep 16, 2025

Uh oh!

Uh oh!

algora-pbc bot commented Sep 16, 2025

Uh oh!

algora-pbc bot commented Sep 16, 2025

Uh oh!

Reviewers

Assignees

Labels

vercel bot commented Sep 12, 2025 •

edited

Loading

seveibar Sep 14, 2025 •

edited

Loading

seveibar Sep 16, 2025 •

edited

Loading