fix: touch to interact work on mobile#255
Merged
imrishabh18 merged 4 commits intotscircuit:mainfrom May 5, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seveibar
reviewed
May 2, 2025
src/PCBViewer.tsx
Outdated
| e.currentTarget.setAttribute( | ||
| "data-touch-start-x", | ||
| touch.clientX.toString(), | ||
| ) |
Contributor
There was a problem hiding this comment.
you should store this using a useRef
seveibar
reviewed
May 2, 2025
seveibar
reviewed
May 2, 2025
src/PCBViewer.tsx
Outdated
| }} | ||
| > | ||
| Click to Interact | ||
| {typeof window !== "undefined" && window.innerWidth < 768 |
Contributor
There was a problem hiding this comment.
not sure i like this approach using window size, it's ok but is there not a better way to detect touch devices? Ipads would fail this test for example
seveibar
reviewed
May 3, 2025
seveibar
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #251
closes #253
/claim #251
Screen.Recording.2025-05-02.at.8.26.51.PM.mov