feat: Improve tsconfig.json parsing and error handling#1318
Merged
ShiboSoftwareDev merged 1 commit intotscircuit:mainfrom Oct 17, 2025
Merged
feat: Improve tsconfig.json parsing and error handling#1318ShiboSoftwareDev merged 1 commit intotscircuit:mainfrom
ShiboSoftwareDev merged 1 commit intotscircuit:mainfrom
Conversation
seveibar
approved these changes
Oct 17, 2025
Contributor
seveibar
left a comment
There was a problem hiding this comment.
now everyone will know why i'm always yelling about silencing errors 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of tsconfig.json files to make
parsing more robust and provide clearer error messages.
• Updated getTsConfig to strip comments from tsconfig.json content before
parsing, as comments are common in these files but not supported by
standard JSON.parse.
• Modified getTsConfig to throw a descriptive error when JSON parsing
fails, making it easier to diagnose malformed configuration files.
• Added a new test case to verify that an invalid tsconfig.json correctly
throws an error.
/claim #1317
/closes #1317