feat: add subcircuit_id and pcb_group_id#539
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch) |
Contributor
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch) |
Contributor
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch) |
Contributor
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch) |
seveibar
reviewed
Jan 21, 2025
Comment on lines
+111
to
+112
| subcircuit_id: string | null = null | ||
| pcb_group_id: string | null = null |
Contributor
There was a problem hiding this comment.
I think it's better to derive these on the fly rather than set them.
Generally you only want to store the ids you're creating so that there's only one source of truth
Suggested change
| subcircuit_id: string | null = null | |
| pcb_group_id: string | null = null |
seveibar
reviewed
Jan 21, 2025
| } | ||
| }), | ||
| stroke_width: props.strokeWidth ?? 0.1, | ||
| subcircuit_id: subcircuit?.subcircuit_id ?? undefined, |
seveibar
reviewed
Jan 21, 2025
seveibar
reviewed
Jan 21, 2025
| extends NormalComponent<Props> | ||
| implements ISubcircuit | ||
| { | ||
| subcircuit_id?: string |
Contributor
There was a problem hiding this comment.
let's bring this back, and also put pcb_group_id here
seveibar
reviewed
Jan 21, 2025
Contributor
seveibar
left a comment
There was a problem hiding this comment.
this PR is mostly correct, just some minor things to move around!
…imitive or normal components
Contributor
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch) |
Contributor
|
@imrishabh18 ok check out my fixes on this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.