Support anchor_position and anchor_alignment for pcb_group#1513
Support anchor_position and anchor_alignment for pcb_group#1513seveibar merged 9 commits intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
seveibar
left a comment
There was a problem hiding this comment.
Good work but you need to add <pcbnotetext or <silkcreentext at different coordinates eg (0,0), (5,5) and (10,10) and also text at the an anchor position with the position and alognment so that its clear from the snapshot that its working
|
@seveibar is it working correctly? |
seveibar
left a comment
There was a problem hiding this comment.
Closer but reading the tests it doesnt seem obvious that the anchor is working. Instead of doing two components in the group maybe do a single dip8 (to make it bigger)
Related but you dont need to immediately address, this code is likely broken for nested groups. Using pcbX/pcbY directly basically always fails for nesting, supposed to use this._getGlobalPcbPositionBeforeLayout
seveibar
left a comment
There was a problem hiding this comment.
I still cant tell if its working, use tscircuit/circuit-to-svg#389
seveibar
left a comment
There was a problem hiding this comment.
Snapshot quality is still low. The 5,5 and 10,10 were just illustrative examples of coordinates, they are useless as used. The 10,10 is supposed to represent the top right of the bounds, you can either move the group or move the text but readability is still really bad. Improve the silkscreen text anchors as well (to the same anchor) for clarity, change size as necessary
seveibar
left a comment
There was a problem hiding this comment.
Please check the snapshots 😭 they are all misaligned
|
Maybe title the snapshot and draw the anchor separately from the text |
|
Please make sure it is super clear whats happening, also in general the bounds of the snapshots are all off, adjust the board so we can see whats happening or have it be autosized (you can set the board anchor for simplicity i think) |
/closes tscircuit/pcb-viewer#408
@seveibar is this how it should be done? or am i overcomplicating this?