Fixed: Edit existing comment rather than reposting#9
Merged
seveibar merged 1 commit intotscircuit:mainfrom Feb 27, 2025
Merged
Conversation
imrishabh18
approved these changes
Feb 26, 2025
Member
imrishabh18
left a comment
There was a problem hiding this comment.
Yeah, even I had a hunch that it is possible that this proxy is the reason and not the workflow. LGTM!
seveibar
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #7
I think there is a syntax issue in the workflow file in the core repo(although I was the one who contributed to that file, which was working fine earlier, now it's giving issues). You can see this pr on my forked repo(fixed workflow file well): https://github.com/MustafaMulla29/core/pull/7
And I tried running the workflow with and without proxy, with proxy it wasn't updating the comment instead it was creating a new comment and without proxy it was successfully updating the existing comment.
I think the issue is in the add-pr-comment-proxy, where you are only creating a new comment and not checking for existing comment.
this is the video of the requests i made with the updated code(checking for an existing comment and updating it):
Screen.Recording.2025-02-23.165106.mp4