Skip to content

Fixed: 3D viewer shouldn't be blank when the board's dimensions are 0#221

Merged
seveibar merged 4 commits intotscircuit:mainfrom
MustafaMulla29:fix/grid-empty-board
Mar 21, 2025
Merged

Fixed: 3D viewer shouldn't be blank when the board's dimensions are 0#221
seveibar merged 4 commits intotscircuit:mainfrom
MustafaMulla29:fix/grid-empty-board

Conversation

@MustafaMulla29
Copy link
Copy Markdown
Contributor

@MustafaMulla29 MustafaMulla29 commented Mar 21, 2025

/claim #214

empty-board.mp4

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
3d-viewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 2:57pm

Copy link
Copy Markdown
Member

@imrishabh18 imrishabh18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks okay, see the comments. Probably a better variable naming could help

@seveibar seveibar merged commit 903f538 into tscircuit:main Mar 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants