Allow an absolute path as dist directory#318
Merged
tschaub merged 2 commits intotschaub:masterfrom Jan 7, 2020
Merged
Conversation
ftm
reviewed
Dec 6, 2019
ftm
left a comment
There was a problem hiding this comment.
Instead of manually handling the absolute path case, you could consider using path.resolve instead of path.join:
> process.cwd()
'/home/user'
> path.join(process.cwd(), "/tmp/hello")
'/home/user/tmp/hello' // incorrect, just joins the paths together in a platform-agnostic way
> path.resolve(process.cwd(), "/tmp/hello")
'/tmp/hello' // correct, actually resolves the absolute path
> path.resolve(process.cwd(), "tmp/hello")
'/home/user/tmp/hello'
Contributor
Author
|
@ftm Good catch! I just have changed. |
tschaub
approved these changes
Jan 7, 2020
Owner
Owner
|
Published with |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It allows using an absolute path to start with
/as the dist directory. The use case is it can be used the dist directory as a path not be under the current directory.It might be a breaking change because of behavior changes on a pass a path to start with
/. Please bump a major version if needed.Fixes: #317