Conversation
17c5f1b to
3f46f02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition that is triggered when
CertificateorCRLget instantiated via multiple threads using the lazy initialization method.This happens in following scenario:
CertificateorCRLinstance is createdCertificate.PEM(), is called from multiple goroutines. This can happen when e.g. test cases are executed in parallel and they access single shared instance ofCertificateorCRLThe fix does not attempt to cover explicitly regenerating certificate and key concurrently by calling
Certificate.Generate()from multiple goroutines. The reason is that it would not be possible to synchronize "accessor" calls such asCertificate.PEM()with the re-generation, so synchronization would need to be on caller side for this use case.Fixes #47