Skip to content

fix(net-ext): Remove lazy static#187

Merged
load1n9 merged 1 commit intomainfrom
fix/remove-lazy-static-net-ext
Nov 6, 2025
Merged

fix(net-ext): Remove lazy static#187
load1n9 merged 1 commit intomainfrom
fix/remove-lazy-static-net-ext

Conversation

@marc2332
Copy link
Member

@marc2332 marc2332 commented Nov 1, 2025

let's make sure I didnt break anything

@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Performance Comparison →

Total Elapsed Time: 46.57ms → 47.63ms (+2.3%)

Profiling Mode: timing - Execution duration of functions.

+-------------------------------------+----------------------+----------------------------------+----------------------------------+--------------------------------+--------------------------------+---------------------------------+------------------------------+
| Function                            | Calls                | Avg                              | P50                              | P95                            | P99                            | Total                           | % Total                      |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+--------------------------------+--------------------------------+---------------------------------+------------------------------+
| andromeda::main                     | 1 → 1 (+0.0%)        | 45.92ms → 46.95ms (+2.3%)        | 45.94ms → 46.96ms (+2.2%)        | 45.94ms → 46.96ms (+2.2%)      | 45.94ms → 46.96ms (+2.2%)      | 45.92ms → 46.95ms (+2.3%)       | 100.00% → 100.00% (+0.0%)    |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+--------------------------------+--------------------------------+---------------------------------+------------------------------+
| andromeda::run_main                 | 1 → 1 (+0.0%)        | 45.90ms → 46.93ms (+2.3%)        | 45.91ms → 46.96ms (+2.3%)        | 45.91ms → 46.96ms (+2.3%)      | 45.91ms → 46.96ms (+2.3%)      | 45.90ms → 46.93ms (+2.3%)       | 99.96% → 99.95% (-0.0%)      |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+--------------------------------+--------------------------------+---------------------------------+------------------------------+
| run::run                            | 1 → 1 (+0.0%)        | 45.39ms → 46.48ms (+2.4%)        | 45.42ms → 46.50ms (+2.4%)        | 45.42ms → 46.50ms (+2.4%)      | 45.42ms → 46.50ms (+2.4%)      | 45.39ms → 46.48ms (+2.4%)       | 98.86% → 99.00% (+0.1%)      |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+--------------------------------+--------------------------------+---------------------------------+------------------------------+
| run::create_runtime_files           | 1 → 1 (+0.0%)        | 45.39ms → 46.48ms (+2.4%)        | 45.42ms → 46.50ms (+2.4%)        | 45.42ms → 46.50ms (+2.4%)      | 45.42ms → 46.50ms (+2.4%)      | 45.39ms → 46.48ms (+2.4%)       | 98.85% → 98.99% (+0.1%)      |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+--------------------------------+--------------------------------+---------------------------------+------------------------------+
| runtime::run                        | 1 → 1 (+0.0%)        | 25.36ms → 26.48ms (+4.4%)        | 25.38ms → 26.49ms (+4.4%)        | 25.38ms → 26.49ms (+4.4%)      | 25.38ms → 26.49ms (+4.4%)      | 25.36ms → 26.48ms (+4.4%)       | 55.24% → 56.39% (+2.1%)      |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+--------------------------------+--------------------------------+---------------------------------+------------------------------+
| runtime::new                        | 1 → 1 (+0.0%)        | 18.69ms → 18.83ms (+0.8%)        | 18.69ms → 18.84ms (+0.8%)        | 18.69ms → 18.84ms (+0.8%)      | 18.69ms → 18.84ms (+0.8%)      | 18.69ms → 18.83ms (+0.8%)       | 40.70% → 40.11% (-1.4%)      |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+--------------------------------+--------------------------------+---------------------------------+------------------------------+
| extension::load                     | 22 → 22 (+0.0%)      | 820.58µs → 824.08µs (+0.4%)      | 302.34µs → 297.22µs (-1.7%)      | 2.91ms → 2.97ms (+2.1%)        | 5.64ms → 5.62ms (-0.4%)        | 18.05ms → 18.13ms (+0.4%)       | 39.31% → 38.61% (-1.8%)      |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+--------------------------------+--------------------------------+---------------------------------+------------------------------+
| console::internal_print             | 180 → 180 (+0.0%)    | 4.35µs → 5.12µs (+17.6%)         | 3.95µs → 5.05µs (+27.9%) ⚠️      | 7.09µs → 5.93µs (-16.3%)       | 14.12µs → 7.14µs (-49.5%) 🚀   | 783.27µs → 920.86µs (+17.6%)    | 1.70% → 1.96% (+15.3%)       |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+--------------------------------+--------------------------------+---------------------------------+------------------------------+
| recommended::recommended_extensions | 1 → 1 (+0.0%)        | 50.31µs → 50.03µs (-0.5%)        | 50.34µs → 50.05µs (-0.6%)        | 50.34µs → 50.05µs (-0.6%)      | 50.34µs → 50.05µs (-0.6%)      | 50.31µs → 50.03µs (-0.5%)       | 0.10% → 0.10% (+0.0%)        |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+--------------------------------+--------------------------------+---------------------------------+------------------------------+
| console::get_group_indent           | 180 → 180 (+0.0%)    | 164.00ns → 213.00ns (+29.9%) ⚠️  | 150.00ns → 200.00ns (+33.3%) ⚠️  | 330.00ns → 351.00ns (+6.4%)    | 461.00ns → 451.00ns (-2.2%)    | 29.57µs → 38.48µs (+30.1%) ⚠️   | 0.06% → 0.08% (+33.3%) ⚠️    |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+--------------------------------+--------------------------------+---------------------------------+------------------------------+

Generated with hotpath

📊 View Raw JSON Metrics

PR Metrics

{
  "hotpath_profiling_mode": "timing",
  "total_elapsed": 47626232,
  "description": "Execution duration of functions.",
  "caller_name": "andromeda::main",
  "output": {
    "runtime::new": {
      "calls": 1,
      "avg": 18833485,
      "p50": 18841599,
      "p95": 18841599,
      "p99": 18841599,
      "total": 18833485,
      "percent_total": 4011
    },
    "runtime::run": {
      "calls": 1,
      "avg": 26481687,
      "p50": 26492927,
      "p95": 26492927,
      "p99": 26492927,
      "total": 26481687,
      "percent_total": 5639
    },
    "console::get_group_indent": {
      "calls": 180,
      "avg": 213,
      "p50": 200,
      "p95": 351,
      "p99": 451,
      "total": 38475,
      "percent_total": 8
    },
    "extension::load": {
      "calls": 22,
      "avg": 824083,
      "p50": 297215,
      "p95": 2971647,
      "p99": 5623807,
      "total": 18129833,
      "percent_total": 3861
    },
    "andromeda::run_main": {
      "calls": 1,
      "avg": 46934367,
      "p50": 46956543,
      "p95": 46956543,
      "p99": 46956543,
      "total": 46934367,
      "percent_total": 9995
    },
    "andromeda::main": {
      "calls": 1,
      "avg": 46953703,
      "p50": 46956543,
      "p95": 46956543,
      "p99": 46956543,
      "total": 46953703,
      "percent_total": 10000
    },
    "recommended::recommended_extensions": {
      "calls": 1,
      "avg": 50034,
      "p50": 50047,
      "p95": 50047,
      "p99": 50047,
      "total": 50034,
      "percent_total": 10
    },
    "run::create_runtime_files": {
      "calls": 1,
      "avg": 46480239,
      "p50": 46497791,
      "p95": 46497791,
      "p99": 46497791,
      "total": 46480239,
      "percent_total": 9899
    },
    "console::internal_print": {
      "calls": 180,
      "avg": 5115,
      "p50": 5051,
      "p95": 5931,
      "p99": 7135,
      "total": 920862,
      "percent_total": 196
    },
    "run::run": {
      "calls": 1,
      "avg": 46484306,
      "p50": 46497791,
      "p95": 46497791,
      "p99": 46497791,
      "total": 46484306,
      "percent_total": 9900
    }
  }
}

Main Branch Metrics

{
  "hotpath_profiling_mode": "timing",
  "total_elapsed": 46569201,
  "description": "Execution duration of functions.",
  "caller_name": "andromeda::main",
  "output": {
    "console::internal_print": {
      "calls": 180,
      "avg": 4351,
      "p50": 3949,
      "p95": 7087,
      "p99": 14119,
      "total": 783268,
      "percent_total": 170
    },
    "extension::load": {
      "calls": 22,
      "avg": 820581,
      "p50": 302335,
      "p95": 2910207,
      "p99": 5644287,
      "total": 18052797,
      "percent_total": 3931
    },
    "run::run": {
      "calls": 1,
      "avg": 45394761,
      "p50": 45416447,
      "p95": 45416447,
      "p99": 45416447,
      "total": 45394761,
      "percent_total": 9886
    },
    "andromeda::main": {
      "calls": 1,
      "avg": 45915664,
      "p50": 45940735,
      "p95": 45940735,
      "p99": 45940735,
      "total": 45915664,
      "percent_total": 10000
    },
    "run::create_runtime_files": {
      "calls": 1,
      "avg": 45389862,
      "p50": 45416447,
      "p95": 45416447,
      "p99": 45416447,
      "total": 45389862,
      "percent_total": 9885
    },
    "runtime::run": {
      "calls": 1,
      "avg": 25363853,
      "p50": 25378815,
      "p95": 25378815,
      "p99": 25378815,
      "total": 25363853,
      "percent_total": 5524
    },
    "runtime::new": {
      "calls": 1,
      "avg": 18691104,
      "p50": 18694143,
      "p95": 18694143,
      "p99": 18694143,
      "total": 18691104,
      "percent_total": 4070
    },
    "recommended::recommended_extensions": {
      "calls": 1,
      "avg": 50306,
      "p50": 50335,
      "p95": 50335,
      "p99": 50335,
      "total": 50306,
      "percent_total": 10
    },
    "console::get_group_indent": {
      "calls": 180,
      "avg": 164,
      "p50": 150,
      "p95": 330,
      "p99": 461,
      "total": 29567,
      "percent_total": 6
    },
    "andromeda::run_main": {
      "calls": 1,
      "avg": 45899283,
      "p50": 45907967,
      "p95": 45907967,
      "p99": 45907967,
      "total": 45899283,
      "percent_total": 9996
    }
  }
}

@load1n9 load1n9 self-requested a review November 3, 2025 20:08
load1n9
load1n9 approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@load1n9 load1n9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@load1n9 load1n9 merged commit 9e57551 into main Nov 6, 2025
8 checks passed
@load1n9 load1n9 deleted the fix/remove-lazy-static-net-ext branch November 6, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@load1n9 load1n9 load1n9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marc2332 @load1n9