Skip to content

feat: implement missing store verbose/strict in compiled binary#172

Merged
load1n9 merged 3 commits intotryandromeda:mainfrom
sajdakabir:feat/store-verbose-strict-in-binary
Oct 21, 2025
Merged

feat: implement missing store verbose/strict in compiled binary#172
load1n9 merged 3 commits intotryandromeda:mainfrom
sajdakabir:feat/store-verbose-strict-in-binary

Conversation

@sajdakabir
Copy link
Contributor

@sajdakabir sajdakabir commented Oct 20, 2025

Fixes #153

Summary

This PR implements the ability to preserve verbose and strict mode settings in compiled binaries. Previously, compiled binaries would always use default settings (non-verbose, strict mode enabled), regardless of how they were intended to be used.

@sajdakabir sajdakabir mentioned this pull request Oct 20, 2025
Closed
@github-actions
Copy link

github-actions bot commented Oct 20, 2025 •
edited
Loading

Performance Comparison →

Total Elapsed Time: 45.14ms → 45.17ms (+0.1%)

Profiling Mode: timing - Execution duration of functions.

+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+----------------------------------+--------------------------------+------------------------------+
| Function                            | Calls                | Avg                             | P50                             | P95                              | P99                              | Total                          | % Total                      |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+----------------------------------+--------------------------------+------------------------------+
| andromeda::main                     | 1 → 1 (+0.0%)        | 44.47ms → 44.50ms (+0.1%)       | 44.50ms → 44.50ms (+0.0%)       | 44.50ms → 44.50ms (+0.0%)        | 44.50ms → 44.50ms (+0.0%)        | 44.47ms → 44.50ms (+0.1%)      | 100.00% → 100.00% (+0.0%)    |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+----------------------------------+--------------------------------+------------------------------+
| andromeda::run_main                 | 1 → 1 (+0.0%)        | 44.45ms → 44.48ms (+0.0%)       | 44.47ms → 44.50ms (+0.1%)       | 44.47ms → 44.50ms (+0.1%)        | 44.47ms → 44.50ms (+0.1%)        | 44.45ms → 44.48ms (+0.0%)      | 99.95% → 99.94% (-0.0%)      |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+----------------------------------+--------------------------------+------------------------------+
| run::run                            | 1 → 1 (+0.0%)        | 43.97ms → 43.96ms (-0.0%)       | 43.97ms → 43.97ms (+0.0%)       | 43.97ms → 43.97ms (+0.0%)        | 43.97ms → 43.97ms (+0.0%)        | 43.97ms → 43.96ms (-0.0%)      | 98.87% → 98.78% (-0.1%)      |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+----------------------------------+--------------------------------+------------------------------+
| run::create_runtime_files           | 1 → 1 (+0.0%)        | 43.97ms → 43.95ms (-0.0%)       | 43.97ms → 43.97ms (+0.0%)       | 43.97ms → 43.97ms (+0.0%)        | 43.97ms → 43.97ms (+0.0%)        | 43.97ms → 43.95ms (-0.0%)      | 98.86% → 98.77% (-0.1%)      |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+----------------------------------+--------------------------------+------------------------------+
| runtime::run                        | 1 → 1 (+0.0%)        | 23.57ms → 23.57ms (+0.0%)       | 23.58ms → 23.58ms (+0.0%)       | 23.58ms → 23.58ms (+0.0%)        | 23.58ms → 23.58ms (+0.0%)        | 23.57ms → 23.57ms (+0.0%)      | 52.98% → 52.97% (-0.0%)      |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+----------------------------------+--------------------------------+------------------------------+
| runtime::new                        | 1 → 1 (+0.0%)        | 19.01ms → 18.93ms (-0.4%)       | 19.02ms → 18.94ms (-0.4%)       | 19.02ms → 18.94ms (-0.4%)        | 19.02ms → 18.94ms (-0.4%)        | 19.01ms → 18.93ms (-0.4%)      | 42.73% → 42.54% (-0.4%)      |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+----------------------------------+--------------------------------+------------------------------+
| extension::load                     | 22 → 22 (+0.0%)      | 832.09µs → 828.36µs (-0.4%)     | 288.77µs → 292.35µs (+1.2%)     | 3.02ms → 2.98ms (-1.3%)          | 5.75ms → 5.78ms (+0.6%)          | 18.31ms → 18.22ms (-0.4%)      | 41.16% → 40.95% (-0.5%)      |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+----------------------------------+--------------------------------+------------------------------+
| console::internal_print             | 180 → 180 (+0.0%)    | 3.61µs → 3.65µs (+1.1%)         | 3.57µs → 3.64µs (+2.0%)         | 4.85µs → 4.73µs (-2.5%)          | 5.44µs → 7.00µs (+28.5%) ⚠️      | 649.97µs → 657.14µs (+1.1%)    | 1.46% → 1.47% (+0.7%)        |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+----------------------------------+--------------------------------+------------------------------+
| recommended::recommended_extensions | 1 → 1 (+0.0%)        | 48.37µs → 52.26µs (+8.0%)       | 48.38µs → 52.29µs (+8.1%)       | 48.38µs → 52.29µs (+8.1%)        | 48.38µs → 52.29µs (+8.1%)        | 48.37µs → 52.26µs (+8.0%)      | 0.10% → 0.11% (+10.0%)       |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+----------------------------------+--------------------------------+------------------------------+
| console::get_group_indent           | 180 → 180 (+0.0%)    | 140.00ns → 91.00ns (-35.0%) 🚀  | 121.00ns → 80.00ns (-33.9%) 🚀  | 301.00ns → 211.00ns (-29.9%) 🚀  | 351.00ns → 481.00ns (+37.0%) ⚠️  | 25.34µs → 16.47µs (-35.0%) 🚀  | 0.05% → 0.03% (-40.0%) 🚀    |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+----------------------------------+--------------------------------+------------------------------+

Generated with hotpath

📊 View Raw JSON Metrics

PR Metrics

{
  "hotpath_profiling_mode": "timing",
  "total_elapsed": 45171388,
  "description": "Execution duration of functions.",
  "caller_name": "andromeda::main",
  "output": {
    "console::internal_print": {
      "calls": 180,
      "avg": 3650,
      "p50": 3637,
      "p95": 4731,
      "p99": 6995,
      "total": 657143,
      "percent_total": 147
    },
    "recommended::recommended_extensions": {
      "calls": 1,
      "avg": 52259,
      "p50": 52287,
      "p95": 52287,
      "p99": 52287,
      "total": 52259,
      "percent_total": 11
    },
    "andromeda::main": {
      "calls": 1,
      "avg": 44498592,
      "p50": 44498943,
      "p95": 44498943,
      "p99": 44498943,
      "total": 44498592,
      "percent_total": 10000
    },
    "andromeda::run_main": {
      "calls": 1,
      "avg": 44475117,
      "p50": 44498943,
      "p95": 44498943,
      "p99": 44498943,
      "total": 44475117,
      "percent_total": 9994
    },
    "console::get_group_indent": {
      "calls": 180,
      "avg": 91,
      "p50": 80,
      "p95": 211,
      "p99": 481,
      "total": 16474,
      "percent_total": 3
    },
    "run::run": {
      "calls": 1,
      "avg": 43958791,
      "p50": 43974655,
      "p95": 43974655,
      "p99": 43974655,
      "total": 43958791,
      "percent_total": 9878
    },
    "runtime::new": {
      "calls": 1,
      "avg": 18931401,
      "p50": 18939903,
      "p95": 18939903,
      "p99": 18939903,
      "total": 18931401,
      "percent_total": 4254
    },
    "runtime::run": {
      "calls": 1,
      "avg": 23571725,
      "p50": 23576575,
      "p95": 23576575,
      "p99": 23576575,
      "total": 23571725,
      "percent_total": 5297
    },
    "run::create_runtime_files": {
      "calls": 1,
      "avg": 43954183,
      "p50": 43974655,
      "p95": 43974655,
      "p99": 43974655,
      "total": 43954183,
      "percent_total": 9877
    },
    "extension::load": {
      "calls": 22,
      "avg": 828362,
      "p50": 292351,
      "p95": 2977791,
      "p99": 5783551,
      "total": 18223982,
      "percent_total": 4095
    }
  }
}

Main Branch Metrics

{
  "hotpath_profiling_mode": "timing",
  "total_elapsed": 45139035,
  "description": "Execution duration of functions.",
  "caller_name": "andromeda::main",
  "output": {
    "extension::load": {
      "calls": 22,
      "avg": 832089,
      "p50": 288767,
      "p95": 3016703,
      "p99": 5750783,
      "total": 18305958,
      "percent_total": 4116
    },
    "runtime::run": {
      "calls": 1,
      "avg": 23566966,
      "p50": 23576575,
      "p95": 23576575,
      "p99": 23576575,
      "total": 23566966,
      "percent_total": 5298
    },
    "andromeda::main": {
      "calls": 1,
      "avg": 44474910,
      "p50": 44498943,
      "p95": 44498943,
      "p99": 44498943,
      "total": 44474910,
      "percent_total": 10000
    },
    "runtime::new": {
      "calls": 1,
      "avg": 19007478,
      "p50": 19021823,
      "p95": 19021823,
      "p99": 19021823,
      "total": 19007478,
      "percent_total": 4273
    },
    "run::create_runtime_files": {
      "calls": 1,
      "avg": 43969014,
      "p50": 43974655,
      "p95": 43974655,
      "p99": 43974655,
      "total": 43969014,
      "percent_total": 9886
    },
    "recommended::recommended_extensions": {
      "calls": 1,
      "avg": 48370,
      "p50": 48383,
      "p95": 48383,
      "p99": 48383,
      "total": 48370,
      "percent_total": 10
    },
    "andromeda::run_main": {
      "calls": 1,
      "avg": 44454132,
      "p50": 44466175,
      "p95": 44466175,
      "p99": 44466175,
      "total": 44454132,
      "percent_total": 9995
    },
    "console::get_group_indent": {
      "calls": 180,
      "avg": 140,
      "p50": 121,
      "p95": 301,
      "p99": 351,
      "total": 25344,
      "percent_total": 5
    },
    "run::run": {
      "calls": 1,
      "avg": 43974424,
      "p50": 43974655,
      "p95": 43974655,
      "p99": 43974655,
      "total": 43974424,
      "percent_total": 9887
    },
    "console::internal_print": {
      "calls": 180,
      "avg": 3610,
      "p50": 3567,
      "p95": 4851,
      "p99": 5443,
      "total": 649972,
      "percent_total": 146
    }
  }
}

@load1n9 load1n9 self-requested a review October 20, 2025 18:41
load1n9
load1n9 requested changes Oct 20, 2025
View reviewed changes
Copy link
Member

@load1n9 load1n9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that was fast! Please fix the formatting but other than that LGTM!

@sajdakabir sajdakabir requested a review from load1n9 October 21, 2025 06:52
@sajdakabir
Copy link
Contributor Author

sajdakabir commented Oct 21, 2025

@load1n9 i've fixed the formatting issue .

load1n9
load1n9 approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@load1n9 load1n9 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the fmt fix, can you also fix the clippy issue before merging?

@sajdakabir sajdakabir requested a review from load1n9 October 21, 2025 19:24
@sajdakabir
Copy link
Contributor Author

sajdakabir commented Oct 21, 2025

thx for the fmt fix, can you also fix the clippy issue before merging?

its done

@load1n9
Copy link
Member

load1n9 commented Oct 21, 2025

LGTM!

@load1n9 load1n9 merged commit 8a23f50 into tryandromeda:main Oct 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@load1n9 load1n9 Awaiting requested review from load1n9

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement missing Store verbose/strict in compiled binary

2 participants

@sajdakabir @load1n9