Skip to content

refactor: make nova_vm features optional#164

Merged
load1n9 merged 2 commits intotryandromeda:mainfrom
xbwwj:optional-nightly
Oct 15, 2025
Merged

refactor: make nova_vm features optional#164
load1n9 merged 2 commits intotryandromeda:mainfrom
xbwwj:optional-nightly

Conversation

@xbwwj
Copy link
Contributor

@xbwwj xbwwj commented Oct 14, 2025

Close #163

@load1n9
Copy link
Member

load1n9 commented Oct 14, 2025

should we add a typescript feature to the andromeda runtime to allow you to enable it if you're embedding and not messing with the novavm crate?

@marc2332
Copy link
Member

Yeah, maybe do a feature for each nova feature

@load1n9 load1n9 self-requested a review October 14, 2025 17:31
@xbwwj
Copy link
Contributor Author

xbwwj commented Oct 14, 2025

I think some high level features like typescript or proposals would suffice. And users should add nova_vm dependencies for fine-grained control (like proposal-float16array).

@xbwwj
Copy link
Contributor Author

xbwwj commented Oct 14, 2025

Yeah, maybe do a feature for each nova feature

To which package should I add these features, core or runtime?

@load1n9
Copy link
Member

load1n9 commented Oct 14, 2025

add them to the runtime package, probably can be assumed if you're including the andromeda core package you're probably using the nova_vm as a dep as well

Copy link
Member

@load1n9 load1n9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the Pr!

@load1n9 load1n9 merged commit ccbc28c into tryandromeda:main Oct 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make nightly features optional

3 participants