feat(ext/http): simple andromeda serve#160
Merged
load1n9 merged 1 commit intotryandromeda:mainfrom Oct 6, 2025
Merged
Conversation
Member
yossydev
commented
Oct 6, 2025
marc2332
reviewed
Oct 6, 2025
Comment on lines
+25
to
+31
| // Global TCP stream storage for accepted connections | ||
| lazy_static::lazy_static! { | ||
| static ref GLOBAL_TCP_STREAMS: Arc<StdMutex<HashMap<u32, Arc<Mutex<TcpStream>>>>> = | ||
| Arc::new(StdMutex::new(HashMap::new())); | ||
| static ref NEXT_STREAM_ID: Arc<StdMutex<u32>> = Arc::new(StdMutex::new(1)); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
No please, no lazy statics with Arcs and mutexes, use the store api of extensions like we use in the rest, e.g fs
andromeda/runtime/src/ext/fs.rs
Line 169 in 23eef73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.