Prevent the RpcClient cleanup thread from cleaning up the client object that is about to be used #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eric-zc1
commented
Jan 15, 2025
- RpcClientProxy的lastUsedNanos使volatile，避免多线程可见性不一致；
- 使用ConcurrentMap的compute，在返回之前updateLastUsedNanos，保证其他线程get的时候拿到的是都是已经更新过最后使用时间的
2. 使用ConcurrentMap的compute，在返回之前updateLastUsedNanos，保证其他线程get的时候拿到的是都是已经更新过最后使用时间的
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
=====================================================
- Coverage 70.14323% 70.11985% -0.02339%
+ Complexity 4241 4239 -2
=====================================================
Files 437 437
Lines 17105 17105
Branches 1727 1727
=====================================================
- Hits 11998 11994 -4
- Misses 3992 3995 +3
- Partials 1115 1116 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.