Skip to content

refactor(server): simplify error creation from unknown causes#6778

Merged
Nick-Lucas merged 1 commit intotrpc:mainfrom
braden-w:unknown-cause-error-building
May 24, 2025
Merged

refactor(server): simplify error creation from unknown causes#6778
Nick-Lucas merged 1 commit intotrpc:mainfrom
braden-w:unknown-cause-error-building

Conversation

@braden-w
Copy link
Contributor

@braden-w braden-w commented May 24, 2025 •
edited
Loading

Updated the getCauseFromUnknown function to use Object.assign for creating a synthetic UnknownCauseError from an object, improving code readability.

🎯 Changes

What changes are made in this PR? Is it a feature or a bug fix?

  • Very minor refactor
  • For normal use cases, this change will behave similarly and is likely preferable
  • But if we rely on copying inherited enumerable properties from cause, then we shouldn't merge, since Object.assign copies only enumerable properties (not inherited ones).

✅ Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

Summary by CodeRabbit

  • Refactor
    • Improved internal handling of error objects for greater efficiency. No changes to user-facing behavior.

@braden-w
refactor(server): simplify error creation from unknown causes
9068261 
Updated the `getCauseFromUnknown` function to use `Object.assign` for creating a synthetic `UnknownCauseError` from an object, improving code readability and efficiency.
@braden-w braden-w requested a review from a team as a code owner May 24, 2025 04:54
@vercel
Copy link

vercel bot commented May 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2025 4:57am

@vercel
Copy link

vercel bot commented May 24, 2025

@braden-w is attempting to deploy a commit to the trpc Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 24, 2025 •
edited
Loading

Walkthrough

The code refactors the getCauseFromUnknown function by replacing a manual property copying loop with a single Object.assign call to merge properties from a cause object into a new UnknownCauseError instance. The function's behavior and public interface remain unchanged.

Changes

File Change Summary
packages/server/src/unstable-core-do-not-import/error/TRPCError.ts Refactored property copying in getCauseFromUnknown to use Object.assign instead of a manual loop.

Poem

A hop and a skip, a loop put to rest,
With Object.assign, the code is now dressed.
No more for-in, just merge and be done,
The error’s new coat is stitched in one run.
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b7cac1d and 9068261.

📒 Files selected for processing (1)
  • packages/server/src/unstable-core-do-not-import/error/TRPCError.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: test
  • GitHub Check: build
  • GitHub Check: Analyze (typescript)
  • GitHub Check: Lint and auto-fix
🔇 Additional comments (1)
packages/server/src/unstable-core-do-not-import/error/TRPCError.ts (1)

25-25: LGTM! Clean refactor that improves readability.

The replacement of manual property copying with Object.assign is an excellent improvement. This approach is more concise, performant, and follows standard JavaScript patterns for object property merging. The behavior remains functionally equivalent for copying enumerable own properties from the cause object to the UnknownCauseError instance.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 24, 2025

Open in StackBlitz

@trpc/client

npm i https://pkg.pr.new/trpc/trpc/@trpc/client@6778

@trpc/next

npm i https://pkg.pr.new/trpc/trpc/@trpc/next@6778

@trpc/react-query

npm i https://pkg.pr.new/trpc/trpc/@trpc/react-query@6778

@trpc/server

npm i https://pkg.pr.new/trpc/trpc/@trpc/server@6778

@trpc/tanstack-react-query

npm i https://pkg.pr.new/trpc/trpc/@trpc/tanstack-react-query@6778

@trpc/upgrade

npm i https://pkg.pr.new/trpc/trpc/@trpc/upgrade@6778

commit: 9068261

@Nick-Lucas Nick-Lucas merged commit 95d1997 into trpc:main May 24, 2025
42 of 45 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2025

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Nick-Lucas Nick-Lucas Nick-Lucas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@braden-w @Nick-Lucas