Fix skipToken in new TRQ client by Nick-Lucas · Pull Request #6564 · trpc/trpc

Nick-Lucas · 2025-02-24T21:57:44Z

…key to begin withwq

Closes #

🎯 Changes

What changes are made in this PR? Is it a feature or a bug fix?

✅ Checklist

I have followed the steps listed in the Contributing guide.
If necessary, I have added documentation related to the changes made.
I have added or updated the tests related to the changes made.

…key to begin withwq

coderabbitai · 2025-02-24T21:57:51Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2025-02-24T21:58:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
next-prisma-starter	✅ Ready (Inspect)	Visit Preview		Feb 26, 2025 9:22am
og-image	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 26, 2025 9:22am
www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 26, 2025 9:22am

pkg-pr-new · 2025-02-24T22:01:04Z

Open in Stackblitz

@trpc/client

npm i https://pkg.pr.new/trpc/trpc/@trpc/client@6564

@trpc/next

npm i https://pkg.pr.new/trpc/trpc/@trpc/next@6564

@trpc/react-query

npm i https://pkg.pr.new/trpc/trpc/@trpc/react-query@6564

@trpc/server

npm i https://pkg.pr.new/trpc/trpc/@trpc/server@6564

@trpc/tanstack-react-query

npm i https://pkg.pr.new/trpc/trpc/@trpc/tanstack-react-query@6564

@trpc/upgrade

npm i https://pkg.pr.new/trpc/trpc/@trpc/upgrade@6564

commit: 34dd559

juliusmarminge · 2025-02-24T22:31:40Z

  opts: AnyTRPCInfiniteQueryOptionsIn;
 }): AnyTRPCInfiniteQueryOptionsOut {
-  const { query, path, queryKey, opts } = args;
-  const inputIsSkipToken = queryKey[1]?.input === skipToken;


this is more explicit which is nice, but why did the previous way not work?

github-actions · 2025-02-27T18:02:20Z

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

Read skipToken from input not from querykey since it's never in query…

1c0fd14

…key to begin withwq

Nick-Lucas marked this pull request as ready for review February 24, 2025 21:57

Nick-Lucas requested a review from a team as a code owner February 24, 2025 21:57

vercel Bot deployed to Preview – og-image February 24, 2025 21:58 View deployment

vercel Bot deployed to Preview – next-prisma-starter February 24, 2025 21:58 View deployment

vercel Bot deployed to Preview – examples-todomvc February 24, 2025 21:58 View deployment

vercel Bot deployed to Preview – trpc-next-app-dir February 24, 2025 21:59 View deployment

vercel Bot deployed to Preview – www February 24, 2025 21:59 View deployment

juliusmarminge reviewed Feb 24, 2025

View reviewed changes

Unused tokens

34dd559

vercel Bot deployed to Preview – og-image February 26, 2025 09:21 View deployment

vercel Bot deployed to Preview – examples-todomvc February 26, 2025 09:21 View deployment

vercel Bot deployed to Preview – next-prisma-starter February 26, 2025 09:21 View deployment

vercel Bot deployed to Preview – trpc-next-app-dir February 26, 2025 09:22 View deployment

vercel Bot deployed to Preview – www February 26, 2025 09:22 View deployment

KATT approved these changes Feb 26, 2025

View reviewed changes

juliusmarminge approved these changes Feb 26, 2025

View reviewed changes

juliusmarminge merged commit bda9a9f into infinite-query-keys Feb 26, 2025

juliusmarminge deleted the fix-skiptoken branch February 26, 2025 13:02

github-actions Bot locked as resolved and limited conversation to collaborators Feb 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix skipToken in new TRQ client#6564

Fix skipToken in new TRQ client#6564
juliusmarminge merged 2 commits into
infinite-query-keysfrom
fix-skiptoken

Nick-Lucas commented Feb 24, 2025

Uh oh!

coderabbitai Bot commented Feb 24, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

vercel Bot commented Feb 24, 2025 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Feb 24, 2025 •

edited

Loading

Uh oh!

juliusmarminge Feb 24, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Nick-Lucas commented Feb 24, 2025

🎯 Changes

✅ Checklist

Uh oh!

coderabbitai Bot commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

vercel Bot commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juliusmarminge Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Feb 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

vercel Bot commented Feb 24, 2025 •

edited

Loading

pkg-pr-new Bot commented Feb 24, 2025 •

edited

Loading

juliusmarminge Feb 24, 2025 •

edited

Loading