Skip to content

Standalone queryoptions package polymorphism#6244

Merged
juliusmarminge merged 4 commits into
standalone-queryoptions-packagefrom
standalone-queryoptions-package-polymorphism
Nov 18, 2024
Merged

Standalone queryoptions package polymorphism#6244
juliusmarminge merged 4 commits into
standalone-queryoptions-packagefrom
standalone-queryoptions-package-polymorphism

Conversation

@Nick-Lucas

@Nick-Lucas Nick-Lucas commented Nov 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Adds polymorphism tests where a shared router type can be used to create shared components
  • Adds queryKey and queryFilter factories with tests
  • Adds InferInput and InferOutput helpers which can be used against Query & Mutation Options factories to get their types

image

🎯 Changes

What changes are made in this PR? Is it a feature or a bug fix?

✅ Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@Nick-Lucas Nick-Lucas requested a review from a team as a code owner November 17, 2024 20:35
@railway-app

railway-app Bot commented Nov 17, 2024

Copy link
Copy Markdown

This PR was not deployed automatically as @Nick-Lucas does not have access to the Railway project.

In order to get automatic PR deploys, please add @Nick-Lucas to the project inside the project settings page.

@Nick-Lucas Nick-Lucas changed the base branch from next to standalone-queryoptions-package November 17, 2024 20:35
@vercel

vercel Bot commented Nov 17, 2024 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-prisma-starter ✅ Ready (Inspect) Visit Preview Nov 17, 2024 9:37pm
og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2024 9:37pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
www ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2024 9:37pm

@Nick-Lucas Nick-Lucas mentioned this pull request Nov 17, 2024
Closed
3 tasks
@pkg-pr-new

pkg-pr-new Bot commented Nov 17, 2024 •
edited
Loading

Copy link
Copy Markdown

Open in Stackblitz

@trpc/client

pnpm add https://pkg.pr.new/trpc/trpc/@trpc/client@6244

@trpc/next

pnpm add https://pkg.pr.new/trpc/trpc/@trpc/next@6244

@trpc/server

pnpm add https://pkg.pr.new/trpc/trpc/@trpc/server@6244

@trpc/react-query

pnpm add https://pkg.pr.new/trpc/trpc/@trpc/react-query@6244

@trpc/tanstack-react-query

pnpm add https://pkg.pr.new/trpc/trpc/@trpc/tanstack-react-query@6244

commit: eb4572d

KATT
KATT reviewed Nov 17, 2024
View reviewed changes
Comment thread packages/tanstack-react-query/src/internals/createOptionsProxy.ts Outdated
@Nick-Lucas Nick-Lucas force-pushed the standalone-queryoptions-package-polymorphism branch from e1aeb54 to eb4572d Compare November 17, 2024 21:35
@juliusmarminge juliusmarminge merged commit 2ea8a84 into standalone-queryoptions-package Nov 18, 2024
@juliusmarminge juliusmarminge deleted the standalone-queryoptions-package-polymorphism branch November 18, 2024 22:14
@github-actions

github-actions Bot commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@KATT KATT KATT left review comments

@juliusmarminge juliusmarminge juliusmarminge approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nick-Lucas @KATT @juliusmarminge