Skip to content

fix: exclude .tsx-tests from build tsconfig#4425

Merged
juliusmarminge merged 21 commits intotrpc:mainfrom
SSHari:patch-4414
May 29, 2023
Merged

fix: exclude .tsx-tests from build tsconfig#4425
juliusmarminge merged 21 commits intotrpc:mainfrom
SSHari:patch-4414

Conversation

@SSHari
Copy link
Copy Markdown
Contributor

@SSHari SSHari commented May 25, 2023

Closes #4414

🎯 Changes

What changes are made in this PR? Is it a feature or a bug fix?

Exclude component tests (i.e. files ending in .tsx) from the tsconfig.build.json file.

✅ Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

Bounty: /claim #4414

@SSHari SSHari requested a review from a team as a code owner May 25, 2023 21:57
@algora-pbc algora-pbc bot mentioned this pull request May 25, 2023
Closed
1 task
@vercel
Copy link
Copy Markdown

vercel bot commented May 25, 2023

@SSHari is attempting to deploy a commit to the trpc Team on Vercel.

A member of the Team first needs to authorize it.

KATT added 2 commits May 26, 2023 00:17
@KATT
glob
f3d9a00
@KATT
Revert "glob"
7d3b7ef 
This reverts commit f3d9a00.
@KATT KATT changed the title fix(next): exclude component tests from build tsconfig fix: exclude .tsx-tests from build tsconfig May 25, 2023
@vercel
Copy link
Copy Markdown

vercel bot commented May 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 10:13am

KATT
KATT previously approved these changes May 25, 2023
View reviewed changes
@KATT KATT enabled auto-merge (squash) May 25, 2023 22:36
juliusmarminge
juliusmarminge previously approved these changes May 29, 2023
View reviewed changes
@juliusmarminge juliusmarminge disabled auto-merge May 29, 2023 09:58
juliusmarminge
juliusmarminge approved these changes May 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuring tsconfigs are fun...

@juliusmarminge juliusmarminge enabled auto-merge (squash) May 29, 2023 10:04
@juliusmarminge juliusmarminge merged commit 33cb8c8 into trpc:main May 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

@KATT KATT KATT left review comments

Assignees

No one assigned

Labels

♻️ autoupdate @trpc/client @trpc/next @trpc/react-query @trpc/server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: get rid of errors when running p dev in /www

3 participants

@SSHari @KATT @juliusmarminge