Skip to content

fix(react-query): useInfiniteQuery treats placeholderData as the source of truth for the types #4378

Closed
KATT wants to merge 4 commits intomainfrom
issues/4360
Closed

fix(react-query): useInfiniteQuery treats placeholderData as the source of truth for the types #4378
KATT wants to merge 4 commits intomainfrom
issues/4360

Conversation

@KATT
Copy link
Copy Markdown
Member

@KATT KATT commented May 17, 2023

#4360

I haven't fixed the bug itself, just added a failing test. Help wanted.

@vercel
Copy link
Copy Markdown

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-prisma-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 8:52pm
og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 8:52pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
www ⬜️ Ignored (Inspect) Visit Preview May 24, 2023 8:52pm

Comment on lines +67 to +69
getNextPageParam(lastPage) {
return lastPage.next;
},
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type errors here

@KATT KATT changed the title fix(react-query): useInfiniteQuery treats placeholderData as the source of truth for the types fix(react-query): useInfiniteQuery treats placeholderData as the source of truth for the types May 17, 2023
@KATT
Copy link
Copy Markdown
Member Author

KATT commented May 18, 2023

Ah, you can also see that it's failing tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🙋‍♂️ help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant