fix(http/metric): fix race condition for HTTP net traffic metric #5861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomatoishealthy
approved these changes
Jun 20, 2024
xxo1shine
approved these changes
Jun 24, 2024
lvs007
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix net traffic metric tracking for HTTP: change endpoint variable from member to local.
Why are these changes required?
The class
HttpInterceptoris a singleton, so the member fieldendpointis shared between users. The single instance is used and re-used to handle multiple requests processed simultaneously by different threads. The result is that one user could see another user's data. In other words, storing user data in Servlet member fields introduces a data access race condition.The
endpointis used for the HTTP net traffic metric, so this statistic is probably wrong.This PR has been tested by:
Follow up
Extra details