Skip to content

feat(log): catch ContractExeException in createShieldedContractParameter #5660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
317787106 merged 2 commits into from
Jan 11, 2024
Merged

feat(log): catch ContractExeException in createShieldedContractParameter #5660

317787106 merged 2 commits into from
Jan 11, 2024

Conversation

@317787106
Copy link
Contributor

@317787106 317787106 commented Jan 11, 2024 •
edited
Loading

What does this PR do?

  • catch ContractExeException in createShieldedContractParameter

Why are these changes required?

  • don't log error if catch predefined exception

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@317787106 317787106 merged commit f9bab7a into tronprotocol:release_v4.7.4 Jan 11, 2024
@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.4 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halibobo1205 halibobo1205 Awaiting requested review from halibobo1205

2 more reviewers

@xxo1shine xxo1shine xxo1shine approved these changes

@jwrct jwrct jwrct approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

GreatVoyage-v4.7.4

Development

Successfully merging this pull request may close these issues.

4 participants

@317787106 @xxo1shine @jwrct @halibobo1205