Skip to content

fix(test): add some test cases of utils #4972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhang0125 merged 1 commit into from
Feb 14, 2023
Merged

fix(test): add some test cases of utils #4972

zhang0125 merged 1 commit into from
Feb 14, 2023

Conversation

@lxcmyf
Copy link
Contributor

@lxcmyf lxcmyf commented Feb 8, 2023 •
edited
Loading

What does this PR do?
add some test cases of utils
Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023 •
edited
Loading

Codecov Report

Merging #4972 (40dcc3b) into feature/unit_test (3664fff) will increase coverage by 0.96%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                   Coverage Diff                   @@
##             feature/unit_test    #4972      +/-   ##
=======================================================
+ Coverage                52.71%   53.68%   +0.96%     
- Complexity                7969     8103     +134     
=======================================================
  Files                      841      841              
  Lines                    49694    49694              
  Branches                  5455     5455              
=======================================================
+ Hits                     26195    26676     +481     
+ Misses                   21375    20834     -541     
- Partials                  2124     2184      +60
Impacted Files Coverage Δ
...src/main/java/org/tron/core/capsule/utils/RLP.java 25.63% <ø> (+6.72%) ⬆️
...in/java/org/tron/common/config/DbBackupConfig.java 70.73% <0.00%> (+4.87%) ⬆️
...main/java/org/tron/core/capsule/utils/RLPList.java 5.88% <0.00%> (+5.88%) ⬆️
.../java/org/tron/common/setting/RocksDbSettings.java 98.38% <0.00%> (+9.67%) ⬆️
...mon/src/main/java/org/tron/common/utils/Value.java 19.84% <0.00%> (+19.84%) ⬆️
...rk/src/main/java/org/tron/keystore/WalletFile.java 28.42% <0.00%> (+28.42%) ⬆️
...k/src/main/java/org/tron/keystore/WalletUtils.java 41.66% <0.00%> (+41.66%) ⬆️
...mework/src/main/java/org/tron/keystore/Wallet.java 49.45% <0.00%> (+46.15%) ⬆️
...main/java/org/tron/core/capsule/utils/RLPItem.java 50.00% <0.00%> (+50.00%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lxcmyf lxcmyf changed the title fix(unitTest): test coverage fix(unit test): test coverage Feb 9, 2023
@lxcmyf lxcmyf force-pushed the feature/unit_test branch 8 times, most recently from a9e17f4 to a300490 Compare February 13, 2023 07:15
@lxcmyf lxcmyf changed the title fix(unit test): test coverage fix(test): increase test coverage Feb 13, 2023
@lxcmyf lxcmyf force-pushed the feature/unit_test branch 8 times, most recently from 033796d to 40dcc3b Compare February 13, 2023 15:38
@lxcmyf lxcmyf changed the title fix(test): increase test coverage fix(test): add some test cases of utils Feb 14, 2023
@zhang0125 zhang0125 merged commit 1ee8957 into tronprotocol:feature/unit_test Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@money42002 money42002 money42002 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lxcmyf @codecov-commenter @money42002 @zhang0125