Add parsing of gutterSettings#506
Merged
Merged
Conversation
Collaborator
|
Looks good to me. Probably it would also make sense to update the unit tests at syntect/src/highlighting/theme_set.rs Line 87 in d3f6d22 |
Contributor
Author
|
Ah, that's a good idea, I was only looking at |
Contributor
Author
|
@keith-hall Are there any more unit tests or anything else you'd like to see before this is merged? |
keith-hall
approved these changes
Feb 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many TextMate2 themes use
gutterSettingsto store colors for the gutter area. This is not supported by Sublime Text. This PR enables usinggutterSettingsto set the foreground and background of the gutter but only if they are not already set insettings.Closes #469