Bump MSRV to 1.53 to fix build with latest time release#422
Merged
Conversation
Contributor
|
Ready to merge? |
Owner
|
(Sorry for lack of responsiveness in the past little while, I'm in the process of moving, once I finish moving by Thursdayish I should hopefully have some time again) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The time crate says
and the release notes for the latest releases made 2 days ago says
This all sounds reasonable to me, so here is a PR to bump our MSRV.
This PR is made in response to this comment. I would advise against the mentioned alternative, to put an upper limit on
time, because soon that will conflict some with other crate that puts an incompatible lower limit ontime. So it's better to just bump MSRV if that is a viable option, which I think is the case here.