For 5.0.0: Split up feature assets into default-syntaxes and default-themes#417
Merged
Merged
Conversation
assets into default-syntaxes and default-themesassets into default-syntaxes and default-themes
Not sure how to make this check make sense when splitting up `assets`, so I'll just remove it. Most likely this is not needed any longer. It was added in e9191a4.
Collaborator
Author
|
Reporter OK:ed this in #310 (comment) |
trishume
approved these changes
Jan 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also specify hard dependencies directly in Cargo.toml instead of asking users to manually enable them. This allows us to simplify cfg directives.
Fixes #310
This will conflict with #407, but that should not affect code review, and I prefer getting this reviewed early over not having to sort out conflicts. The conflicts shouldn't be that bad.