Fix query parameters encoding in rewritten target requests#205
Merged
vagaerg merged 1 commit intotrinodb:mainfrom Dec 8, 2025
Merged
Fix query parameters encoding in rewritten target requests#205vagaerg merged 1 commit intotrinodb:mainfrom
vagaerg merged 1 commit intotrinodb:mainfrom
Conversation
0be84e6 to
3c63818
Compare
Fixes request rewriting when query parameters contain a value that matches a percent-encoded value (e.g. `%2F`). Previously, such values were not encoded when adding query parameters to the rewritten request, as the method used internally by `JerseyUriBuilder.queryParam` to encode values (UriComponent.contextualEncode) is recognizing percent-encoded values to avoid double-encoding. This led to changing the original request, and subsequently the remote denying the request with `SignatureDoesNotMatch` error. To fix this, we can encode all query parameter values before passing them to the URI builder, as we know that they require encoding.
3c63818 to
dbfe71e
Compare
vagaerg
approved these changes
Dec 8, 2025
Member
vagaerg
left a comment
There was a problem hiding this comment.
LGTM - nice catch, as we decode them when building a request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes request rewriting when query parameters contain a value that matches a percent-encoded value (e.g.
%2F).Previously, such values were not encoded when adding query parameters to the rewritten request, as the method used internally by
JerseyUriBuilder.queryParamto encode values (UriComponent.contextualEncode) is recognizing percent-encoded values to avoid double-encoding. This led to changing the original request, and subsequently the remote denying the request withSignatureDoesNotMatcherror.To fix this, we can encode all query parameter values before passing them to the URI builder, as we know that they require encoding.