Skip to content

.NET 10 upgrade#135

Merged
DavidWiseman merged 1 commit into
trimble-oss:mainfrom
DavidWiseman:DotNet10
Nov 28, 2025
Merged

.NET 10 upgrade#135
DavidWiseman merged 1 commit into
trimble-oss:mainfrom
DavidWiseman:DotNet10

Conversation

@DavidWiseman

Copy link
Copy Markdown
Collaborator

Update project to target .NET 10.
Update nuget packages.
Update workflows

Update project to target .NET 10.
Update nuget packages.
Update workflows
@DavidWiseman DavidWiseman requested a review from Copilot November 28, 2025 14:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the project from .NET 8.0 to .NET 10.0, updating target frameworks, NuGet package dependencies, and CI/CD workflow configurations to support the new runtime version.

Key Changes:

  • Updated target framework from net8.0 to net10.0 across all projects
  • Upgraded NuGet packages to versions compatible with .NET 10
  • Updated GitHub Actions workflows to use .NET 10.0.x runtime

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sql-log-shipping-service/LogShippingService.csproj Updated target framework to net10.0-windows7.0 and upgraded 10 NuGet packages to .NET 10-compatible versions
sql-log-shipping-service-tests/LogShippingServiceTests.csproj Updated test project target framework to net10.0-windows7.0 and upgraded MSTest packages to version 4.0.2
.github/workflows/tag-create-release.yml Updated dotnet-version from 8.0.x to 10.0.x
.github/workflows/codeql-analysis.yml Updated dotnet-version from 8.0.x to 10.0.x
.github/workflows/build.yml Updated dotnet-version from 8.0.x to 10.0.x
.github/workflows/build copy.yml Updated dotnet-version from 8.0.x to 10.0.x

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


<PropertyGroup>
<TargetFramework>net8.0-windows</TargetFramework>
<TargetFramework>net10.0-windows7.0</TargetFramework>

Copilot AI Nov 28, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The target framework specifies net10.0-windows7.0 while the main project uses the same. However, the original test project used net8.0-windows without the version suffix. Consider whether the Windows 7.0 API level is necessary for tests, or if net10.0-windows would be more appropriate for consistency.

Suggested change
<TargetFramework>net10.0-windows7.0</TargetFramework>
<TargetFramework>net10.0-windows</TargetFramework>

Copilot uses AI. Check for mistakes.
@DavidWiseman DavidWiseman merged commit 8351ca8 into trimble-oss:main Nov 28, 2025
@DavidWiseman DavidWiseman deleted the DotNet10 branch November 28, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants