Merged
Conversation
🦋 Changeset detectedLatest commit: 95cdc4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9 tasks
Member
|
@Chigala I made some changes to the Remix PR before merging it.
Can you make sure that these aren't issues in this PR? I'll continue looking at new framework PRs tomorrow. |
Contributor
Author
|
No matter how hard I try,I still end up with some bad syntax here and there😭😅. Thanks @matt-aitken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 1 - Astro Adapter
astro.examples/astro-examplefolder.Task 2 - Add a README.md file
README.mdfile inside thepackages/astrofolder.Task 3 - Write the documentation
manual-setup-astro.mdxfile in/docs/_snippets/.client-adaptors.mdxpage with the astro framework.Task 4 - Update the webapp onboarding
route.tsxpage located in_app.orgs.$organizationSlug.projects.$projectParam.setup.astro, replaced the<FrameworkComingSoon/>component with new onboarding steps.FrameworkSelector.tsxfile, add "supported" to the framework you’ve worked on.I didn't include trigger init CLI support for the framework because I don't know what the Trigger team has in mind concerning how to handle initialization for the other separate frameworks. If this is needed I don't mind implementing it. I'll also love your feedback on this!
Also, to run trigger CLI dev command you'll need node v18.14.1 and then comment out the node fetch package and use the native fetch. Talked more about this on discord
/claim #452
/closes #452